Merged
Conversation
Report for GZ2E01 (58a6d8d - aca0d94)📈 Matched code: 77.05% (+0.10%, +11776 bytes) ✅ 44 new matches
...and 14 more new matches 📈 18 improvements in unmatched functions
|
hatal175
reviewed
Aug 11, 2025
include/d/actor/d_a_npc_coach.h
Outdated
| /* 0x0F0 */ cXyz field_0xf0[10]; | ||
| /* 0x168 */ f32 field_0x168; | ||
| /* 0x16C */ s8 field_0x16c; | ||
| /* 0x16D */ u8 field_0x16d[0x170 - 0x16d]; |
Contributor
There was a problem hiding this comment.
field_0x16d can be removed
include/d/actor/d_a_npc_coach.h
Outdated
| /* 0x1C */ s16 field_0x1c; | ||
| /* 0x1E */ s16 field_0x1e; | ||
| /* 0x20 */ s16 field_0x20; | ||
| /* 0x22 */ u8 field_0x22[0x24 - 0x22]; |
Contributor
There was a problem hiding this comment.
I don't think field_0x22 is needed. not sure though
include/d/actor/d_a_npc_coach.h
Outdated
| /* 0x798 */ s16 mCoachRot; | ||
| /* 0x79A */ csXyz field_0x79a; | ||
| /* 0x7A0 */ csXyz field_0x7a0; | ||
| /* 0x7A6 */ u8 field_0x7a6[0x7a8 - 0x7a6]; |
src/d/actor/d_a_npc_coach.cpp
Outdated
| 16.0f, | ||
| 62.0f, | ||
| -58.837898f, | ||
| 67.626999f, |
Contributor
There was a problem hiding this comment.
This might be a quirk with beautify_anm_data. @carter-ktb21 , please confirm.
Contributor
Author
There was a problem hiding this comment.
nope that was my bad!
src/d/actor/d_a_npc_coach.cpp
Outdated
|
|
||
| if (field_0x24c0 < 5) { | ||
| for (int i = 0; i < 5; i++) { | ||
| if (field_0x247c[i] == 0xFFFFFFFF) { |
src/d/actor/d_a_npc_coach.cpp
Outdated
| sVar2 = -0x1194; | ||
| } | ||
|
|
||
| if (sVar1 > 0x1194) { |
Contributor
There was a problem hiding this comment.
That's 4500 in decimal - seems prettier
Contributor
There was a problem hiding this comment.
💯. @carter-ktb21 , if you're using objdiff 3+, you can right click hex values to see their decimal values. If the number looks prettier as decimal, then use decimal.
TakaRikka
reviewed
Aug 12, 2025
include/d/actor/d_a_e_kr.h
Outdated
Comment on lines
+21
to
+22
| inline s32 getId() { return field_0xf00; } | ||
| inline s32 checkBombDrop() { return field_0xf04; } |
Contributor
There was a problem hiding this comment.
inline keyword shouldnt be needed here since its declared in-class
include/d/actor/d_a_npc_coach.h
Outdated
|
|
||
| struct daNpcChPath_c { | ||
| inline BOOL setPath(int, int, cXyz*, bool); | ||
| inline BOOL isClose() { return dPath_ChkClose(mpPath); } |
Contributor
There was a problem hiding this comment.
same thing with the in-class inlines here
include/d/actor/d_a_npc_coach.h
Outdated
| /* 0x9C */ s32 deceleration_time; // 減速時間 - Deceleration Time | ||
| }; | ||
|
|
||
| struct daNpcChReins_c { |
Contributor
There was a problem hiding this comment.
structs that end with _c are presumed to be classes originally
include/d/actor/d_a_npc_theB.h
Outdated
Comment on lines
+54
to
+55
| inline void setTRMtx(MtxP mtx) { mpMorf->getModel()->setBaseTRMtx(mtx); } | ||
| inline void setGameOver() { mGameOver = 1; } |
Contributor
There was a problem hiding this comment.
same thing about inlines here
src/d/actor/d_a_npc_coach.cpp
Outdated
| param_1 = 0; | ||
| uVar2 = 0; | ||
| attention_info.flags = 0; | ||
| } else { |
Contributor
There was a problem hiding this comment.
can these else nested be condensed?
src/d/actor/d_a_npc_coach.cpp
Outdated
| attention_info.flags = 0; | ||
| } else { | ||
| if (mCoachBlazing) { | ||
| // uVar2 = param_1; |
hatal175
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.