Ensure defaultValue is always applied in the case of nulls #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
defaultanddefaultValueproperties are applied from functions in the case ofnullorundefined(see https://github.com/zemirco/json2csv/blob/v4/lib/JSON2CSVBase.js#L81), but onlyundefinedfor simple properties (https://github.com/zemirco/json2csv/blob/v4/lib/utils.js#L4). I also noticed that the tests fordefaultValuewere accidentally relying on thenull->""transformation, so I updated them to exercise the behavior better.