Add dynamic sizing to base collection view#11
Merged
vadymmarkov merged 5 commits intomasterfrom Oct 5, 2015
Merged
Conversation
Collaborator
There was a problem hiding this comment.
I think we could have some lazy var view instead of func render, because now we're creating the view 2 times, here and in cellForItemAtIndexPath.
Owner
Author
There was a problem hiding this comment.
@vadymmarkov Is that really true when dealing with reference types? render() is just returning the lazy loaded component from inside.
Collaborator
There was a problem hiding this comment.
@zenangst Yeah, forgot what we have in render 😃
Collaborator
|
@zenangst This is awesome ⭐ |
vadymmarkov
added a commit
that referenced
this pull request
Oct 5, 2015
…ions Add dynamic sizing to base collection view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this JSON, it will render the following;