(breaking)mpd: support float durations for SegmentTemplate #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcasinclair
suggested changes
Jan 9, 2020
| SegmentTimeline *SegmentTimeline `xml:"SegmentTimeline,omitempty"` | ||
| PresentationTimeOffset *uint64 `xml:"presentationTimeOffset,attr,omitempty"` | ||
| Duration *int64 `xml:"duration,attr"` | ||
| Duration *float64 `xml:"duration,attr"` |
There was a problem hiding this comment.
Can you explain more the driver for this? Not only is it likely to break most implementations but doesn't look like it lines up with the DASH spec
There was a problem hiding this comment.
Yup, took a look and agree with you, the xsd types this as xs:unsignedInt. @flavioribeiro can you add more info on the background here?
https://standards.iso.org/ittf/PubliclyAvailableStandards/MPEG-DASH_schema_files/DASH-MPD.xsd
|
Closing this, the change doesn't conform to the DASH spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this change on behalf of @flavioribeiro, broken out of this PR: #62
This PR introduces an incompatibility with previous versions.