add support for EventStreams #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soldiermoth
reviewed
Feb 5, 2020
soldiermoth
reviewed
Feb 5, 2020
soldiermoth
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted to not add support for the
xlink:hrefandxlink:actuateattributes forEventStreammainly because I was trying to do it in a clean way to support all elements that have thexlinkattributes (Period,AdaptationSet,EventStream,SegmentList), using an embedded struct, but due to some issues with the way marshaling namespaced xml attributes works, I was trying to do something similar to theContentProtectMarshalstruct go-dash uses. However, since thexlinkis not meant to be an element, but just attributes on the embedded struct, it wouldn't work quite the same. I decided it was better to tackle that problem separately rather than bundle it into this PR.