moving to 1.0.0, combining user info and attributes in calls #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
usmanity
commented
May 8, 2015
usmanity
commented
- adding timestamp
- updating readme
lib/outbound.rb
Outdated
There was a problem hiding this comment.
don't you need to add a timestamp param to this method as well?
|
Couple comments. Make sure timestamp works. With what you've done, a timestamp will always be set, it just doesn't accept one as a parameter so the library makes the timestamp every time. |
usmanity
added a commit
that referenced
this pull request
May 12, 2015
moving to 1.0.0, combining user info and attributes in calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.