Rails main testing #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zendesk-edytaroz
force-pushed
the
edytaroz/rails_main_testing
branch
from
8f99564 to
45c3691
Compare
zendesk-edytaroz
force-pushed
the
edytaroz/rails_main_testing
branch
from
45c3691 to
26031b1
Compare
zendesk-edytaroz
force-pushed
the
edytaroz/rails_main_testing
branch
2 times, most recently
from
ac932e3 to
7aba9e8
Compare
razumau
reviewed
Aug 13, 2024
zendesk-edytaroz
force-pushed
the
edytaroz/rails_main_testing
branch
from
7aba9e8 to
99cb17e
Compare
razumau
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the upper boundary on the rails requirement. It is done for the purpose of creating a workflow that tests the library with the current version of rails.
After having done that, it turned out that in the new versions of ActiveRecord some methods had been relocated from ActiveRecord::ConnectionAdapters::AbstractAdapter to ActiveRecord::ConnectionAdapters::ConnectionPool rails/rails@a918394