Report consumer lag to StatsD when processing batches #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
❤️ I'll cherry-pick this to the 0.4 branch as well. |
|
@dasch Did this get into 0.4.3 or any 0.4.x release? It says its included in the changelog but the v0.4.3 branch is missing this change. Thanks! |
Contributor
|
@Shadowssong there hasn't been a release of v0.4.x since the cherry pick. I won't release that series very often, as the main line of development is now v0.5. |
|
@dasch Gotcha thanks for the update, may be worth removing this change from the 0.4.3 release changelog then https://github.com/zendesk/ruby-kafka/blame/master/CHANGELOG.md#L22 |
Contributor
|
I've released v0.4.4 with the latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it possible to merge this to 0.4.x release too ?