Skip to content

Decode 0.9-format messages #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Decode 0.9-format messages #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/kafka/protocol/message.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,21 @@ def self.decode(decoder)

crc = message_decoder.int32
magic_byte = message_decoder.int8
attributes = message_decoder.int8

unless magic_byte == MAGIC_BYTE
# The magic byte indicates the message format version. There are situations
# where an old message format can be returned from a newer version of Kafka,
# because old messages are not necessarily rewritten on upgrades.
case magic_byte
when 0
# No timestamp in the pre-0.10 message format.
timestamp = nil
when 1
timestamp = message_decoder.int64
else
raise Kafka::Error, "Invalid magic byte: #{magic_byte}"
end

attributes = message_decoder.int8
timestamp = message_decoder.int64
key = message_decoder.bytes
value = message_decoder.bytes

Expand Down