Skip to content

Conversation

@fbvilela
Copy link
Contributor

@fbvilela fbvilela commented Jun 8, 2023

Tries to make CBP requests when page is not specified. If the request raises an error it retries without the cbp specifics

@fbvilela fbvilela force-pushed the fvilela/red-1497 branch from 2474c46 to e7c57f6 Compare June 9, 2023 00:52
@fbvilela fbvilela force-pushed the fvilela/red-1497 branch from e7c57f6 to 232033e Compare June 9, 2023 00:54
@ecoologic ecoologic changed the title [DRAFT] RED - 1497 [DRAFT] RED-1497 Ruby Client CBP by default Jun 9, 2023
@fbvilela fbvilela force-pushed the fvilela/red-1497 branch from 36befbc to fd93249 Compare June 9, 2023 07:17
@fbvilela fbvilela force-pushed the fvilela/red-1497 branch from fd93249 to 57cc825 Compare June 9, 2023 07:37
@fbvilela fbvilela marked this pull request as ready for review June 13, 2023 02:24
@fbvilela fbvilela requested a review from a team as a code owner June 13, 2023 02:25
@ecoologic ecoologic changed the title [DRAFT] RED-1497 Ruby Client CBP by default RED-1497 Ruby Client CBP by default Jun 13, 2023
@ecoologic ecoologic force-pushed the fvilela/red-1497 branch 2 times, most recently from bf10b43 to 5fff9f0 Compare June 14, 2023 03:45
end

block.call(*arguments)
block.call(resource, @options["page"] || 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any reason why these two versions should behave differently -> simplifying.

Copy link
Contributor

@JinHuangMelb JinHuangMelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecoologic ecoologic merged commit 677fdd5 into master Jun 14, 2023
@ecoologic ecoologic deleted the fvilela/red-1497 branch June 14, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants