-
Notifications
You must be signed in to change notification settings - Fork 185
RED-1497 Ruby Client CBP by default #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2474c46 to
e7c57f6
Compare
e7c57f6 to
232033e
Compare
36befbc to
fd93249
Compare
fd93249 to
57cc825
Compare
ecoologic
reviewed
Jun 12, 2023
37a67b2 to
fac1154
Compare
ecoologic
reviewed
Jun 13, 2023
ecoologic
reviewed
Jun 13, 2023
ecoologic
reviewed
Jun 13, 2023
ecoologic
reviewed
Jun 14, 2023
ecoologic
reviewed
Jun 14, 2023
bf10b43 to
5fff9f0
Compare
ecoologic
reviewed
Jun 14, 2023
| end | ||
|
|
||
| block.call(*arguments) | ||
| block.call(resource, @options["page"] || 1) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of any reason why these two versions should behave differently -> simplifying.
JinHuangMelb
approved these changes
Jun 14, 2023
Contributor
JinHuangMelb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5fff9f0 to
3b14c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to make CBP requests when
pageis not specified. If the request raises an error it retries without the cbp specifics