[CRYSTAL-574] Fix: remove escaped quotes and standardize trigger parameters in validation messages #401

zendesk-punavwalke · 2025-10-16T09:28:37Z

💐

/cc @zendesk/wattle

Description

Fixes YAML formatting issues and parameter inconsistencies in Custom Objects V2 validation error messages.

Key Changes:

Fixed display issue: Removed "" wrapper quotes that caused \ prefix/suffix to appear in error messages
Parameter correction: Replaced %{trigger_title} with %{trigger_key} as unique identifier
Translation management: Created updated entries and marked old ones as obsolete (2025-12-31)
Improved consistency: Standardized error message patterns across all Custom Objects V2 validations

References

JIRA: https://zendesk.atlassian.net/browse/CRYSTAL-574

Before merging this PR

Fill out the Risks section
Think about performance and security issues

Risks

[low] Updating only translations. This changes are not consumed in any of the zas versions.

- Remove the \ prefix and suffix in strings wrapped in double quotes

Copilot

Pull Request Overview

Fixes YAML formatting issues and parameter inconsistencies in Custom Objects V2 validation error messages to improve display quality and ensure consistent parameter usage.

Removed escaped quotes that caused \ prefixes/suffixes to appear in error messages
Replaced %{trigger_title} with %{trigger_key} as the standardized unique identifier for triggers
Created new translation entries with corrected formatting and marked obsolete entries with deprecation dates

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-16T11:51:09Z

config/locales/translations/zendesk_apps_support.yml

+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_cov2_object_reference_in_fields_v2"
+      title: 'App builder job: requirements file contains an invalid object reference in object_fields for Custom Objects V2. Do not translate "requirements.json", "object_fields", %{item_identifier},  %{object_key}.'
+      value: The requirements.json file contains an invalid object reference in object_fields. Field %{item_identifier} references object %{object_key} which does not exist in the objects array.


The value field is missing quotes around the string value, which is inconsistent with the YAML format used throughout the rest of the file.

Suggested change

value: The requirements.json file contains an invalid object reference in object_fields. Field %{item_identifier} references object %{object_key} which does not exist in the objects array.

value: "The requirements.json file contains an invalid object reference in object_fields. Field %{item_identifier} references object %{object_key} which does not exist in the objects array."

Copilot · 2025-10-16T11:51:09Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/1yHiq5uUyGmQjLgO72ARAVCgFA1tXFUHT/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_cov2_object_reference_in_triggers_v2"
+      title: 'App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Do not translate "requirements.json", "object_fields", %{item_identifier}, %{object_key}.'


The title references 'object_fields' in the translation note, but this validation message is for 'object_triggers'. The note should reference 'object_triggers' instead of 'object_fields'.

Suggested change

title: 'App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Do not translate "requirements.json", "object_fields", %{item_identifier}, %{object_key}.'

title: 'App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Do not translate "requirements.json", "object_triggers", %{item_identifier}, %{object_key}.'

alok2806 · 2025-10-16T12:00:49Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/1peD9NjuFQ6_dW4ia6Cxz-GimTN0rdjMk/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.missing_cov2_trigger_schema_key_v2"
+      title: 'App builder job: requirements file is missing a custom object trigger schema key. These are the required keys: (title, actions, conditions, object_key). The term \"schema key\" typically refers to an identifier or attribute that defines a specific item within a schema and it should be translated. Leave requirements.json as is (do not translate)'


Suggested change

title: 'App builder job: requirements file is missing a custom object trigger schema key. These are the required keys: (title, actions, conditions, object_key). The term \"schema key\" typically refers to an identifier or attribute that defines a specific item within a schema and it should be translated. Leave requirements.json as is (do not translate)'

title: 'App builder job: requirements file is missing a custom object trigger schema key. These are the required keys: (title, actions, conditions, object_key). The term "schema key" typically refers to an identifier or attribute that defines a specific item within a schema and it should be translated. Leave requirements.json as is (do not translate)'

alok2806 · 2025-10-16T12:08:14Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/1hTiBvSHqEXCsoa2YAt1bnGNCs8cXSzlx/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_cov2_trigger_actions_structure_v2"
+      title: "App builder job: requirements file contains an invalid custom object trigger actions structure. Actions must be an array. 'actions' is part of requirements file. Leave requirements.json and 'actions' as is (do not translate)"


Suggested change

title: "App builder job: requirements file contains an invalid custom object trigger actions structure. Actions must be an array. 'actions' is part of requirements file. Leave requirements.json and 'actions' as is (do not translate)"

title: "App builder job: requirements file contains an invalid custom object trigger actions structure. Actions must be an array. 'actions' is part of requirements file. Leave requirements.json as is (do not translate). 'actions' is part of the schema and shouldn't be translated (do not translate)."

alok2806 · 2025-10-16T12:09:04Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/1UeBrY4GlnHDK19zuUE8xUoHnZl9HQv3y/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.empty_cov2_trigger_actions_v2"
+      title: "App builder job: requirements file contains empty custom object trigger actions. At least one action must be specified. Leave requirements.json as is (do not translate)"


Suggested change

title: "App builder job: requirements file contains empty custom object trigger actions. At least one action must be specified. Leave requirements.json as is (do not translate)"

title: "App builder job: requirements file contains empty custom object trigger actions. At least one action must be specified. Leave requirements.json as is (do not translate). 'actions' is part of the schema and shouldn't be translated (do not translate)."

alok2806 · 2025-10-16T12:10:15Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/1ywYAYOoeVmjUgZ2yfFl3YdJ-xkrBSgUG/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_object_fields_structure_in_cov2_requirements_v2"
+      title: "App builder job: requirements file contains invalid object_fields structure for custom objects v2. Object_fields must be an array. Leave requirements.json and 'object_fields' as is (do not translate)"


Suggested change

title: "App builder job: requirements file contains invalid object_fields structure for custom objects v2. Object_fields must be an array. Leave requirements.json and 'object_fields' as is (do not translate)"

title: "App builder job: requirements file contains invalid object_fields structure for custom objects v2. Object_fields must be an array. Leave requirements.json as is (do not translate). 'object_fields' is part of the schema and shouldn't be translated (do not translate). "

alok2806 · 2025-10-16T12:11:01Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/1ishzANlbt4PiyxikwXDTTPKy9drlWWlP/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_cov2_requirements_structure_v2"
+      title: 'App builder job: requirements file contains invalid custom objects v2 structure. An "object" here refers to a programming object (a set of key-value pairs), not a custom object in Zendesk. Leave requirements.json, custom_objects_v2 as is (do not translate)'


Suggested change

title: 'App builder job: requirements file contains invalid custom objects v2 structure. An "object" here refers to a programming object (a set of key-value pairs), not a custom object in Zendesk. Leave requirements.json, custom_objects_v2 as is (do not translate)'

title: 'App builder job: requirements file contains invalid custom objects v2 structure. An "object" here refers to a programming object (a set of key-value pairs), not a custom object in Zendesk. Leave 'requirements.json' as is (do not translate). 'custom_objects_v2' is part of the schema and shouldn't be translated (do not translate).'

alok2806 · 2025-10-16T12:12:13Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/1TQSnKbBXxLSYFpcgEBGNceLpo5ARMBAa/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_object_triggers_structure_in_cov2_requirements_v2"
+      title: "App builder job: requirements file contains invalid object_triggers structure for custom objects v2. Object_triggers must be an array. Leave requirements.json and 'object_triggers' as is (do not translate)"


Suggested change

title: "App builder job: requirements file contains invalid object_triggers structure for custom objects v2. Object_triggers must be an array. Leave requirements.json and 'object_triggers' as is (do not translate)"

title: "App builder job: requirements file contains invalid object_triggers structure for custom objects v2. Object_triggers must be an array. Leave requirements.json as is (do not translate). 'object_triggers' is part of the schema and shouldn't be translated (do not translate)."

alok2806 · 2025-10-16T12:13:09Z

config/locales/translations/zendesk_apps_support.yml

+      screenshot: "https://drive.google.com/file/d/19r2xv15OnXtu2-JxU_ioAVMmaP33DiB-/view?usp=sharing"
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_cov2_object_reference_in_fields_v2"
+      title: 'App builder job: requirements file contains an invalid object reference in object_fields for Custom Objects V2. Do not translate "requirements.json", "object_fields", %{item_identifier},  %{object_key}.'


Suggested change

title: 'App builder job: requirements file contains an invalid object reference in object_fields for Custom Objects V2. Do not translate "requirements.json", "object_fields", %{item_identifier}, %{object_key}.'

title: 'App builder job: requirements file contains an invalid object reference in object_fields for Custom Objects V2. Do not translate "requirements.json", "object_fields" as this is a schema key, %{item_identifier}, %{object_key}.'

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

config/locales/translations/zendesk_apps_support.yml

zenfw

LGTM

fix: consistency in cov2 validation error messages

fe4ea29

- Remove the \ prefix and suffix in strings wrapped in double quotes

zendesk-punavwalke changed the title ~~fix: consistency in cov2 validation error messages~~ [CRYSTAL-574] Fix: remove escaped quotes and standardize trigger parameters in validation messages Oct 16, 2025

fix: rename existing strings to avoid conflicits

76b2c82

zendesk-punavwalke force-pushed the zendesk-punavwalke/translation-cleanup branch from 66ed247 to 76b2c82 Compare October 16, 2025 11:44

zendesk-punavwalke marked this pull request as ready for review October 16, 2025 11:50

zendesk-punavwalke requested a review from a team as a code owner October 16, 2025 11:50

Copilot AI review requested due to automatic review settings October 16, 2025 11:50

Copilot AI reviewed Oct 16, 2025

View reviewed changes

alok2806 reviewed Oct 16, 2025

View reviewed changes

fix: translations title

36510c6

zendesk-punavwalke requested a review from Copilot October 16, 2025 12:45

Copilot AI reviewed Oct 16, 2025

View reviewed changes

config/locales/translations/zendesk_apps_support.yml Show resolved Hide resolved

config/locales/translations/zendesk_apps_support.yml Show resolved Hide resolved

config/locales/translations/zendesk_apps_support.yml Show resolved Hide resolved

zendesk-punavwalke requested a review from alok2806 October 16, 2025 12:52

alok2806 approved these changes Oct 16, 2025

View reviewed changes

alok2806 added the g11n-approved Approved by Globalization label Oct 16, 2025

zenfw approved these changes Oct 16, 2025

View reviewed changes

zendesk-punavwalke merged commit 9c00f3f into main Oct 17, 2025
5 checks passed

zendesk-punavwalke deleted the zendesk-punavwalke/translation-cleanup branch October 17, 2025 07:41

	value: The requirements.json file contains an invalid object reference in object_fields. Field %{item_identifier} references object %{object_key} which does not exist in the objects array.
	value: "The requirements.json file contains an invalid object reference in object_fields. Field %{item_identifier} references object %{object_key} which does not exist in the objects array."

	title: 'App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Do not translate "requirements.json", "object_fields", %{item_identifier}, %{object_key}.'
	title: 'App builder job: requirements file contains an invalid object reference in object_triggers for Custom Objects V2. Do not translate "requirements.json", "object_triggers", %{item_identifier}, %{object_key}.'

	title: "App builder job: requirements file contains an invalid custom object trigger actions structure. Actions must be an array. 'actions' is part of requirements file. Leave requirements.json and 'actions' as is (do not translate)"
	title: "App builder job: requirements file contains an invalid custom object trigger actions structure. Actions must be an array. 'actions' is part of requirements file. Leave requirements.json as is (do not translate). 'actions' is part of the schema and shouldn't be translated (do not translate)."

[CRYSTAL-574] Fix: remove escaped quotes and standardize trigger parameters in validation messages #401

[CRYSTAL-574] Fix: remove escaped quotes and standardize trigger parameters in validation messages #401

Uh oh!

Conversation

zendesk-punavwalke commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

References

Before merging this PR

Risks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

alok2806 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

alok2806 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

alok2806 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

alok2806 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

alok2806 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

alok2806 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

alok2806 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zenfw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zendesk-punavwalke commented Oct 16, 2025 •

edited

Loading