Skip to content

Conversation

@atroche
Copy link
Contributor

@atroche atroche commented Feb 5, 2014

requirements_json was throwing an exception when the file wasn't there.

@danielbreves
Copy link
Contributor

👍

1 similar comment
@liulikun
Copy link

liulikun commented Feb 5, 2014

👍

@svizzari
Copy link
Contributor

svizzari commented Feb 5, 2014

Should the read_json method be able to handle that? Do we need to raise an Exception elsewhere?

@atroche
Copy link
Contributor Author

atroche commented Feb 5, 2014

read_json will have to throw an exception if it can't find the file — it'd be really ugly to return nil. And I think a “file not found” exception is descriptive enough to let people know what's going on.

atroche added a commit that referenced this pull request Feb 5, 2014
Check for requirements.json without trying to read it
@atroche atroche merged commit d84ac85 into master Feb 5, 2014
@svizzari
Copy link
Contributor

svizzari commented Feb 5, 2014

@atroche Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants