fix(modals): correct padding for various header/body/footer layouts #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consistent stacking with variable padding based on optional flex children is, well ... hard.
Detail
See "Various Dialog Layouts" section under https://garden.zendesk.com/css-components/modals/ – published for review. Note that, in order to stack consistently, it's left as an exercise to the consumer to add 20px of padding to the bottom of a dialog with no footer.
@Austin94 when this rolls into
react-componentswe should update the three examples under https://garden.zendesk.com/react-components/modals/#!/Modal/5 to style the parentModalwithpaddingBottom: 20(for a total of 40px whitespace at the bottom of the modals).Checklist
designer as a reviewer)
yarn start)(
.is-hovered,.is-focused, etc.)?bedrock=false)custom.cssexample for modifying theprimary accent color