Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Oct 20, 2018

  • BREAKING CHANGE?

Description

Provide consistent header/body/footer stacking...

  • whether or not a footer is included
  • despite modal dialog element ordering
  • for both default & large dialog sizes

Detail

See zendeskgarden/css-components#134 for details.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.781% when pulling 75c76fc on jzempel/modal-fix into 2a7c986 on master.

Copy link
Contributor

@austingreendev austingreendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm going to hold off deployment until all of the Github data consistency issues are fixed. Otherwise the webhooks might not trigger Travis.

@jzempel jzempel merged commit 83a4cb9 into master Oct 22, 2018
@jzempel jzempel deleted the jzempel/modal-fix branch October 22, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants