Skip to content

fix(dropdowns): menu item anchor styling #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2021
Merged

fix(dropdowns): menu item anchor styling #1168

merged 3 commits into from
Aug 25, 2021

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Aug 25, 2021

Description

Improve handling for <a> or Garden <Anchor> added as a menu Item child.

Detail

before

Screen Shot 2021-08-25 at 2 52 47 PM

after

Screen Shot 2021-08-25 at 2 53 57 PM

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from a team as a code owner August 25, 2021 18:57
@coveralls
Copy link

coveralls commented Aug 25, 2021

Coverage Status

Coverage remained the same at 94.835% when pulling 75f5e75 on jzempel/menu-anchor into 05d4789 on main.

@zendesk-garden zendesk-garden temporarily deployed to staging August 25, 2021 19:23 Inactive
@ghost
Copy link

ghost commented Aug 25, 2021 •
edited by ghost
Loading

Bojagi review status

All stories are approved! 🎉

Following stories have changed:

  • Components/Dropdowns/Multiselect
  • Components/Avatars
  • Components/Dropdowns/Autocomplete
  • Components/Tables
  • Components/Dropdowns/Select
  • Components/Notifications/Toasts
  • Components/Dropdowns/Combobox
  • Components/Buttons/SplitButton
  • Components/Accordions/Accordion
  • Components/Dropdowns/Menu

See all stories: https://bojagi.io/app/github/zendeskgarden/react-components/pull/1168

@jzempel jzempel merged commit f552d3b into main Aug 25, 2021
@jzempel jzempel deleted the jzempel/menu-anchor branch August 25, 2021 22:03
lucijanblagonic
lucijanblagonic reviewed Aug 26, 2021
View reviewed changes
Copy link

@lucijanblagonic lucijanblagonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucijanblagonic lucijanblagonic lucijanblagonic left review comments

+1 more reviewer

@hzhu hzhu hzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jzempel @coveralls @lucijanblagonic @hzhu @zendesk-garden