Skip to content

docs: update Autocomplete examples to have correct maxHeight #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2018
Merged

docs: update Autocomplete examples to have correct maxHeight #222

merged 3 commits into from
Dec 4, 2018

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Dec 4, 2018

Description

Our examples were incorrectly applying a fixed height rather than a maxHeight to our dropdowns. This PR corrects those examples.

Before

autocompleteheight

After

autocompletemaxheight

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested review from a team, allisonacs, ginnywood, jzempel and ryanseddon and removed request for jzempel and ryanseddon December 4, 2018 18:55
@coveralls
Copy link

coveralls commented Dec 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 94.751% when pulling b8212e0 on agreen/autocomplete-examples-update into 100dd08 on master.

allisonacs
allisonacs approved these changes Dec 4, 2018
View reviewed changes
Copy link

@allisonacs allisonacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL OF THE APPROVALS FOR THIS ONE

jzempel
jzempel reviewed Dec 4, 2018
View reviewed changes
@austingreendev austingreendev merged commit 4bdc25d into master Dec 4, 2018
@austingreendev austingreendev deleted the agreen/autocomplete-examples-update branch December 4, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzempel jzempel jzempel approved these changes

+2 more reviewers

@allisonacs allisonacs allisonacs approved these changes

@ginnywood ginnywood ginnywood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@austingreendev @coveralls @jzempel @allisonacs @ginnywood