Skip to content

docs: update Autocomplete examples to have correct maxHeight #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2018
Merged

docs: update Autocomplete examples to have correct maxHeight #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4962091
docs: update Autocomplete examples to have correct maxHeight
austingreendev Dec 4, 2018
507b19c
Update RSG example renderer font sizes
austingreendev Dec 4, 2018
b8212e0
Move to style block
Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/autocomplete/src/examples/autocomplete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ initialState = {
}
})}
>
<div style={{ height: '200px', overflowY: 'auto' }}>{menuItems}</div>
<div style={{ maxHeight: '200px', overflowY: 'auto' }}>{menuItems}</div>
<Separator />
<AddItem {...addItemProps}>Add item</AddItem>
</MenuView>
Expand Down
2 changes: 1 addition & 1 deletion packages/autocomplete/src/examples/multiselect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ const MoreAnchor = styled(Anchor)`
}
})}
>
<div style={{ height: '150px', overflowY: 'auto' }}>
<div style={{ maxHeight: '150px', overflowY: 'auto' }}>
{getMatchingMenuItems(
state.inputValue,
state.selectedKeys,
Expand Down
10 changes: 9 additions & 1 deletion utils/styleguide/styleguide.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ const {
zdColorBlue600,
zdColorGrey100,
zdColorKale400,
zdColorRed600
zdColorRed600,
zdFontSizeMd
} = require('@zendeskgarden/css-variables');
const packageManifest = require(path.resolve('package.json'));
const customStyleguideConfig = require(path.resolve('styleguide.config.js'));
Expand Down Expand Up @@ -46,6 +47,13 @@ const defaultStyleguideConfig = {
type: zdColorRed600
}
},
styles: {
StyleGuide: {
'@global body': {
fontSize: zdFontSizeMd
}
}
},
template: {
lang: 'en',
head: {
Expand Down