feat: refactor matchExports to getExports #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanseddon
reviewed
Dec 6, 2018
| Enzyme.configure({ adapter: new Adapter() }); | ||
|
|
||
| // Enable async/await | ||
| import '@babel/polyfill'; |
Contributor
There was a problem hiding this comment.
Do we need this if we're running in a node version that supports it natively?
Contributor
Author
There was a problem hiding this comment.
From what I could tell, yes 😭 The jest environment is slightly different
Contributor
Author
There was a problem hiding this comment.
Would continually run into regeneratorRuntime errors
ryanseddon
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My original implementation of
matchExportsincluded a nestedexpect😢and wasn't the most readable.This PR adds a
BREAKING CHANGEtoreact-testingby removing thematchExportsutility with a more generalizedgetExports.I've also updated all necessary tests to use asyn/await as necessary.
Checklist
designer as a reviewer)
component
yarn start)