chore: add export testing to all packages #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
reviewed
Dec 5, 2018
Member
jzempel
left a comment
jzempel
left a comment
There was a problem hiding this comment.
Along with the common code abstraction, consider whether it makes sense to remove the associated PR checklist item from https://github.com/zendeskgarden/react-components/blob/master/.github/PULL_REQUEST_TEMPLATE.md
Contributor
Author
I've removed this checklist item and also added a new |
jzempel
approved these changes
Dec 6, 2018
ryanseddon
reviewed
Dec 6, 2018
|
|
||
| const mappedFiles = fileMapper(files); | ||
|
|
||
| expect(keys).toEqual(mappedFiles); |
Contributor
There was a problem hiding this comment.
should we really have the expect hidden away in another module? Can we have this method just return mapped files and then in each test we do the expect there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds root export testing to all packages. This is to help reduce incidents where we forget to add a new component/utility to the root export. Similar to #211
Detail
These tests use a
globutility to help with finding the components. Since each package is unique it was difficult to add with the standardreaddirnode methods.A few of the packages (loaders/tooltips) needed some custom logic to match the expected exports, but overall the method is consistent.