Skip to content

feat(buttons): add ChevronButton export #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzempel merged 1 commit into from
Jul 30, 2018
Merged

feat(buttons): add ChevronButton export #86

jzempel merged 1 commit into from
Jul 30, 2018

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Jul 30, 2018

  • BREAKING CHANGE?

Description

Add ChevronButton to package exports.

Detail

closes #84

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📒 any new files are included in the packages src/index.js export
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested review from AbhiPrasad and ryanseddon July 30, 2018 21:04
@coveralls
Copy link

coveralls commented Jul 30, 2018

Pull Request Test Coverage Report for Build 318

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.146%
Totals Coverage Status
Change from base Build 317: 0.0%
Covered Lines: 1685
Relevant Lines: 1699
💛 - Coveralls

AbhiPrasad
AbhiPrasad approved these changes Jul 30, 2018
View reviewed changes
Copy link

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to this so quickly!

@jzempel jzempel merged commit 4bae854 into master Jul 30, 2018
@jzempel jzempel deleted the jzempel/chevron-button branch July 30, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanseddon ryanseddon Awaiting requested review from ryanseddon

1 more reviewer

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ChevronButton does not work

4 participants

@jzempel @coveralls @AbhiPrasad