Skip to content

fix(container-utilities): coerce useId return value to string #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix(container-utilities): coerce useId return value to string #701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/utilities/src/utils/useId.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ let idCounter = 0;
*
* @returns A generated ID that can be passed to accessibility attributes
*/
export const useId = (id?: any) => useReachId(id) || `id:${idCounter++}`;
export const useId = (id?: any) => `${useReachId(id)}` || `id:${idCounter++}`;
Copy link
Contributor Author

@ze-flo ze-flo Aug 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the TypeScript returnType hasn’t changed and is still a 'string', the actual type of the returned value has and could, in rare situations, cause runtime errors.

Should that be a breaking-change?

Copy link
Member

@jzempel jzempel Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so – this feels like a fix.