Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Conversation

@DaanBiesterbos
Copy link

Hi,

I developed a generator for interfaces and the method declarations. I felt like sharing today. Reflection classes and tests are included.

Cheers,
Daan

.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo this. Instead add your custom files in your global gitignore

@DaanBiesterbos
Copy link
Author

@Maks3w Done :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license should be on top of namespace like others. @author should be before class

@Martin-P
Copy link

Martin-P commented Jun 6, 2015

Please fix all docblocks and remove stuff like this:

* Class InterfaceGenerator
* @package   Zend\Code\Generator
* @author    Daan Biesterbos <daanbiesterbos@gmail.com>
* @filesource

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use short array syntax []

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsonik I switched to use short array syntax. I would like to know if this is a real guideline. I see -alot- of old fashioned array() statements in this project. I don't mind using one or the other. But I don't like doing the same thing twice. Is there some sort of document available?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanBiesterbos Recently the rule has been applied b1ddef7

Ocramius added a commit that referenced this pull request Sep 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants