Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Conversation

@samsonasik
Copy link
Contributor

added Predicate\Expression to its @params

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?

This is to give user information that the $on parameter can be a Zend\Db\Sql\Predicate\Expression

@froschdesign froschdesign added this to the 2.9.2 milestone Dec 9, 2017
@samsonasik
Copy link
Contributor Author

@froschdesign should be pointed to 2.9.3 since 2.9.2 already released

@froschdesign
Copy link
Member

It's already 2.9.3. Please look at the right sidebar and in the milestone.

@ezimuel ezimuel merged commit 98f49ac into zendframework:master Apr 9, 2018
@ezimuel
Copy link
Contributor

ezimuel commented Apr 9, 2018

@samsonasik thanks!

@samsonasik samsonasik deleted the patch-1 branch April 9, 2018 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants