Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

@svycka
Copy link
Contributor

@svycka svycka commented Sep 11, 2015

When running tests locally there was one failing test:

There was 1 failure:

1) ZendTest\Form\View\Helper\FormRowTest::testIgnoreLabelForHidden
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<input type="hidden" name="foo" value=""/>'
+'<input type="hidden" name="foo" value="">'

/vagrant/projects/zend-form/test/View/Helper/FormRowTest.php:124

@Maks3w
Copy link
Member

Maks3w commented Sep 11, 2015

What php version are you using?

@svycka
Copy link
Contributor Author

svycka commented Sep 11, 2015

$ php -v
PHP 5.6.13-1+deb.sury.org~trusty+2 (cli)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies
with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2015, by Zend Technologies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with append ? plus escape the slash is enough

value=""\/?>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sow that other tests using this regexp so I used too don't know why they did it like this. But I can change if you think its better

@Maks3w Maks3w self-assigned this Sep 11, 2015
@Maks3w Maks3w added this to the 2.6.0 milestone Sep 11, 2015
Maks3w added a commit that referenced this pull request Sep 11, 2015
Maks3w added a commit that referenced this pull request Sep 11, 2015
@Maks3w Maks3w merged commit 31a14d1 into zendframework:master Sep 11, 2015
Maks3w added a commit that referenced this pull request Sep 11, 2015
@Maks3w Maks3w removed this from the 2.6.0 milestone Sep 11, 2015
@svycka svycka deleted the hotfix/fixed-failing-test branch September 11, 2015 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants