Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

fixed failing test #13

Merged
merged 1 commit into from
Sep 11, 2015
Merged

fixed failing test #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/View/Helper/FormRowTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function testIgnoreLabelForHidden()
$element = new Element\Hidden('foo');
$element->setLabel('My label');
$markup = $this->helper->render($element);
$this->assertEquals('<input type="hidden" name="foo" value=""/>', $markup);
$this->assertRegexp('/<input type="hidden" name="foo" value=""[^\/>]*\/?>/', $markup);
Copy link
Member

@Maks3w Maks3w Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with append ? plus escape the slash is enough

value=""\/?>

Copy link
Contributor Author

@svycka svycka Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sow that other tests using this regexp so I used too don't know why they did it like this. But I can change if you think its better

}

public function testCanHandleMultiCheckboxesCorrectly()
Expand Down