This repository was archived by the owner on Jan 30, 2020. It is now read-only.
using "Cookie|false" instead of "Cookie|bool" for docblock Request::getCookie() #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Jun 23, 2018
| * | ||
| * @convenience $request->getHeaders()->get('Cookie'); | ||
| * @return Header\Cookie|bool | ||
| * @return Header\Cookie|false |
Member
There was a problem hiding this comment.
false is not a type: it's a value.
This change is invalid, sorry.
Contributor
Author
There was a problem hiding this comment.
@Ocramius Type can be explicit boolean value based on it http://docs.phpdoc.org/guides/types.html
Member
There was a problem hiding this comment.
That's still not a type - even if phpdocumentor supports it, that is a mistake
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As when no "Cookie" header, it will return false.