Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

using "Cookie|false" instead of "Cookie|bool" for docblock Request::getCookie() #152

Closed
wants to merge 1 commit into from
Closed

using "Cookie|false" instead of "Cookie|bool" for docblock Request::getCookie() #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ public function getPost($name = null, $default = null)
* Return the Cookie header, this is the same as calling $request->getHeaders()->get('Cookie');
*
* @convenience $request->getHeaders()->get('Cookie');
* @return Header\Cookie|bool
* @return Header\Cookie|false
Copy link
Member

@Ocramius Ocramius Jun 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false is not a type: it's a value.

This change is invalid, sorry.

Copy link
Contributor Author

@samsonasik samsonasik Jun 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius Type can be explicit boolean value based on it http://docs.phpdoc.org/guides/types.html

Copy link
Member

@Ocramius Ocramius Jun 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's still not a type - even if phpdocumentor supports it, that is a mistake

*/
public function getCookie()
{
Expand Down