This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Use callable type hint instead of a comment #272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
`callable` is supported since PHP 5.4
…On 30 Jan 2018 21:10, "Aleksei Khudiakov" ***@***.***> wrote:
callable typehint is not available in php 5.6 which is the minimum
supported version
https://github.com/zendframework/zend-mvc/blob/
0cb6770/composer.json#L20
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#272 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakMz9R_C74Fp4Y3d6j8oJRJ-5RshKks5tP3dJgaJpZM4Ry2hq>
.
|
Member
|
It is. I confused it for iterable. Deleted comment immediately but mail already went out. |
Xerkus
added a commit
that referenced
this pull request
Feb 17, 2019
Member
|
Adding a parameter typehint could be a BC break if someone extended and overrode the method. Merging it for the next major. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use callable type hint instead of a comment