This repository was archived by the owner on Jan 29, 2020. It is now read-only.
change substr() check with strrpos at InjectTemplateListener::deriveControllerClass() #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samsonasik
commented
May 7, 2018
samsonasik
commented
- Is this related to quality assurance?
…veControllerClass()
Contributor
Author
|
after some check, it is actually needed, ref https://3v4l.org/umaZC |
Contributor
Author
|
strrpos still possible, but with keep the strlen() usage, ref https://3v4l.org/I2N7t |
samsonasik
changed the title
Member
michalbundyra
left a comment
michalbundyra
left a comment
There was a problem hiding this comment.
Not convinced to this change, imo it decreased readability.
| && ('Controller' == substr($controller, -10)) | ||
| $length = strlen($controller); | ||
| if ($length > 10 | ||
| && strrpos($controller, 'Controller') === ($length - 10) |
Member
There was a problem hiding this comment.
Brackets are useless around ($length - 10).
Member
|
I would agree with @webimpress, this PR in its final form does not bring notable improvement. I am going to close this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.