Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Conversation

@panvid
Copy link

@panvid panvid commented May 16, 2018

No description provided.

@Xerkus
Copy link
Member

Xerkus commented Feb 17, 2019

I am not sure about this. It does not add any functionality to zend-mvc.

@Xerkus Xerkus self-assigned this Feb 17, 2019
@froschdesign
Copy link
Member

froschdesign commented Feb 17, 2019

@Xerkus
If an end-user wants to use the LazyControllerAbstractFactory in his application, then zend-serializer is required – but only there.
Therefore the hint / suggestion in the Composer file for this soft dependency.

use Zend\Serializer\AdapterPluginManager as SerializerAdapterManager;

At the moment we have no reference or guide for the Composer file, but we use the suggest section since the introduction of Composer.

@Xerkus
Copy link
Member

Xerkus commented Feb 17, 2019

Neither use statement or magic ::class constant require presence or existence of the referenced class. It is just a glorified string literal. I would argue this use case does not create soft dependency.

Controller requiring serializer adapter plugin manager as dependency would need to declare zend-serializer as a dependency on the other hand.

@froschdesign
Copy link
Member

@Xerkus
You are right! The factory doesn't use the serializer for running.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants