This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Add phpstan tool #303
Merged
Add phpstan tool #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Xerkus this diff is massive: are there commits that we can exclude from it? Version bump maybe? |
Member
Author
Member
|
@Xerkus CS patch is merged too 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added phpstan static analyser tool but did not provide fixes for errors it detected.
Next major will necessary have wide reaching changes that will discard big chunk of possible fixes that can be done now. For this reason it is not included in travis builds at this time.
This PR adds static analysis tool to drive code quality in future development
Based on top of #302