This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fixed failure when implementing custom rbac roles#4210
Closed
tux-rampage wants to merge 3 commits intozendframework:masterfrom
tux-rampage:rbac-issue
Closed
Fixed failure when implementing custom rbac roles#4210tux-rampage wants to merge 3 commits intozendframework:masterfrom tux-rampage:rbac-issue
tux-rampage wants to merge 3 commits intozendframework:masterfrom
tux-rampage:rbac-issue
Conversation
When adding custom roles which implement Zend\Permissions\Rbac\RoleInterface, an UnexpectedValueException is thrown due to missing RecursiveIterator implementation. Fixed this exception by improving the hasChildren() implementation in Zend\Permissions\Rbac\AbstractIterator
Contributor
|
👍 |
Removed the leading slash from interface name string passed to getMockForAbstractClass().
The @return annotation for Zend\Permissions\Rbac\Rbac::addRole() is incorrect. This method returns $this and not the rule instance.
Member
There was a problem hiding this comment.
This should be simply self.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2013
Fixed failure when implementing custom rbac roles
weierophinney
added a commit
that referenced
this pull request
Apr 12, 2013
weierophinney
added a commit
to zendframework/zend-permissions-rbac
that referenced
this pull request
May 15, 2015
…rbac-issue Fixed failure when implementing custom rbac roles
weierophinney
added a commit
to zendframework/zend-permissions-rbac
that referenced
this pull request
May 15, 2015
- docblock can simply refer to "self"
weierophinney
added a commit
to zendframework/zend-permissions-rbac
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-permissions-rbac
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zend\Permissions\Rbac\Rbac::isGranted()will faill, when implementing the interfaceZend\Permissions\Rbac\RoleInterfacewith a custom role and adding it to aZend\Permissions\Rbac\Rbacinstance with parents (due to missing implementation of RecursiveIterator on the custom role).This example will throw an UnexpectedValueException ("Objects returned by RecursiveIterator::getChildren() must implement RecursiveIterator").
Zend\Permissions\Rbac\AbstractIterator