Skip to content

Cahllagerfeld/fix dimenstions #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Cahllagerfeld/fix dimenstions #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aa0965
refactor: remove dimensions from SidebarHeader Icon
Cahllagerfeld Oct 23, 2023
0baf705
chore: add changeset
Cahllagerfeld Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-jeans-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@zenml-io/react-component-library": patch
---

remove dimenstions from SidebarHeader Icon
10 changes: 5 additions & 5 deletions src/components/Sidebar/Sidebar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const defaultStory: Story = {
args: {
children: (
<>
<SidebarHeader icon={<CloseButton />} title="ZenML Tenant">
<SidebarHeader icon={<CloseButton className="w-6 h-6" />} title="ZenML Tenant">
<SidebarHeaderImage>
<img src={`https://avatar.vercel.sh/ZenMLTenant?size=32`} />
</SidebarHeaderImage>
Expand All @@ -50,29 +50,29 @@ export const defaultStory: Story = {
<li className="w-full">
<SidebarItem isActive={true}>
<div>
<SidebarItemContent isActive={true} icon={<CPU />} label="Models" />
<SidebarItemContent svgStroke isActive={true} icon={<CPU />} label="Models" />
</div>
</SidebarItem>
</li>
<li className="w-full">
<SidebarItem isActive={false}>
<div>
<SidebarItemContent isActive={false} icon={<CPU />} label="Models" />
<SidebarItemContent svgStroke isActive={false} icon={<CPU />} label="Models" />
</div>
</SidebarItem>
</li>
<li className="w-full">
<SidebarItem isActive={false}>
<div>
<SidebarItemContent isActive={false} icon={<CPU />} label="Models" />
<SidebarItemContent svgStroke isActive={false} icon={<CPU />} label="Models" />
</div>
</SidebarItem>
</li>
</SidebarList>
<div style={{ marginTop: "auto" }}>
<SidebarItem>
<div>
<SidebarItemContent isActive={false} icon={<CPU />} label="Models" />
<SidebarItemContent svgStroke isActive={false} icon={<CPU />} label="Models" />
</div>
</SidebarItem>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Sidebar/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const SidebarHeader = forwardRef<HTMLDivElement, SidebarHeaderProps>(

const iconClasses = cn(
existingIconClasses,
"w-6 ml-auto shrink-0 h-6 opacity-0 group-hover:opacity-100 duration-300 transition-all"
"ml-auto shrink-0 opacity-0 group-hover:opacity-100 duration-300 transition-all"
);

return (
Expand Down
2 changes: 1 addition & 1 deletion src/components/Sidebar/SidebarHeader.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const sidebarHeader: Story = {
name: "Sidebar Header",
args: {
title: "ZenML Tenant",
icon: <CloseButton />,
icon: <CloseButton className="w-6 h-6" />,
children: (
<SidebarHeaderImage>
<img src={`https://avatar.vercel.sh/ZenMLTenant?size=32`} />
Expand Down
4 changes: 2 additions & 2 deletions src/components/Sidebar/SidebarItem.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const inactive: Story = {
isActive: false,
children: (
<div>
<SidebarItemContent icon={<CPU />} label="Models" />
<SidebarItemContent svgStroke icon={<CPU />} label="Models" />
</div>
)
}
Expand All @@ -39,7 +39,7 @@ export const active: Story = {
isActive: true,
children: (
<div>
<SidebarItemContent isActive={true} icon={<CPU />} label="Models" />
<SidebarItemContent svgStroke isActive={true} icon={<CPU />} label="Models" />
</div>
)
}
Expand Down