Add Toast Component #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzin-escandia
approved these changes
Apr 10, 2024
| import type { ToastActionElement, ToastProps } from "./Toast"; | ||
|
|
||
| const TOAST_LIMIT = 2; | ||
| const TOAST_REMOVE_DELAY = 1000000; |
There was a problem hiding this comment.
16 min and 40 secs, is this not too much? 😅
There was a problem hiding this comment.
you're actually correct, this is used inside a setTimeout it seems to be the default though. And where its used it seems fine 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✨ Add Toast Component
Checklist
Please make sure that your pull request complies with the following requirements:
Code Quality:
Testing:
Documentation:
Review:
Security:
Screenshots (optional)