Skip to content

feature/add-dialog #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2024
Merged

feature/add-dialog #67

merged 3 commits into from
Apr 11, 2024

Conversation

@atzin-escandia
Copy link
Contributor

@atzin-escandia atzin-escandia commented Apr 10, 2024 •
edited
Loading

Description

✨ Add Dialog component

Checklist

Please make sure that your pull request complies with the following requirements:

  • Code Quality:

    • 🧹 Code follows the project's coding guidelines.

  • Testing:

    • 🧪️ All existing tests pass successfully.

  • Documentation:

    • 📖 README and documentation are updated if necessary.

  • Review:

    • 👀 Code has been reviewed by a team member.

  • Security:

    • 🔒 Changes don't introduce security vulnerabilities.

Screenshots (optional)

Screenshot 2024-04-11 at 10 01 04

Cahllagerfeld
Cahllagerfeld reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@Cahllagerfeld Cahllagerfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, I'll check the storybook entry in the pr itself 👍

Cahllagerfeld
Cahllagerfeld reviewed Apr 11, 2024
View reviewed changes
@atzin-escandia atzin-escandia merged commit ea30076 into main Apr 11, 2024
@Cahllagerfeld Cahllagerfeld mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cahllagerfeld Cahllagerfeld Cahllagerfeld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atzin-escandia @Cahllagerfeld