Add Option to keep sidebar open #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cahllagerfeld
force-pushed
the
feature/update-sidebar
branch
from
42e1fe9 to
c11436e
Compare
atzin-escandia
approved these changes
Apr 11, 2024
| export function AppShell({ children }: { children: ReactNode }) { | ||
| return ( | ||
| <div style={{ minHeight: "100vh", display: "flex", flexDirection: "column", width: "100%" }}> | ||
| <div style={{ minHeight: "1000px", display: "flex", flexDirection: "column", width: "100%" }}> |
There was a problem hiding this comment.
Just out of curiosity, this 1000px instead of a full vh is ok? 🤔
There was a problem hiding this comment.
Its just for the storybook preview, if I put it 100vh I need to scroll xD I just dont want to scroll when viewing it, so i set it to a fixed height 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✨ Add context to the sidebar to keep it open
Checklist
Please make sure that your pull request complies with the following requirements:
Code Quality:
Testing:
Documentation:
Review:
Security:
Screenshots (optional)