Skip to content

Conversation

@AlexejPenner
Copy link
Contributor

Describe changes

I have started working on the examples and wanted to check in early to see if this is what you had in mind?

For now I would appreciate just a quick glance without going into detail so that I can know if I'm going into the correct direction.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@AlexejPenner AlexejPenner changed the base branch from main to develop March 31, 2022 05:41
@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Mar 31, 2022
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look at this, but I guess this PR got overshadowed by our conversation in discord.

As one piece of context, it was the nba-pipeline zenfile that originally made me think that the examples wanted beautifying. So I would suggest that (depending on what we end up doing with the examples etc) maybe as a first step for beautifying these individual entities would be to give them the same love and care (emojis, diagrams, clear explanations etc) that you gave the nba-pipeline zenfile? But that of course is pending our bigger decisions about what's happening to the examples in the first place...

Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small chunk of changes for the Introduction docs section

Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer guide comments

Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have some more comments:

  • We have a lot of overlap between the sections stack components, core concepts and glossary. Do they all have a different scope or can we somehow link to each other to prevent duplicated efforts?
  • Our "placeholders" in CLI commands are all over the place:
    • Some are just uppercase: zenml stack register STACK_NAME
    • Some are with dollar signs: zenml stack register $STACK_NAME (or $stack_name)
    • Some are with these guys <>: zenml stack register <STACK_NAME>
      I vote for having these unified, with a preference for the last option mainly as gitbook already colors them (<>) differently and therefore makes it easier to detect placeholder values

Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Copy link
Contributor

@schustmi schustmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More random comments

AlexejPenner and others added 6 commits May 4, 2022 17:36
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
…io/zenml into feature/ENG-634-beautify-examples
@AlexejPenner AlexejPenner merged commit 9dc549e into develop May 5, 2022
@AlexejPenner AlexejPenner deleted the feature/ENG-634-beautify-examples branch May 5, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request internal To filter out internal PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants