-
Notifications
You must be signed in to change notification settings - Fork 559
Beautification of Examples #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
strickvl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look at this, but I guess this PR got overshadowed by our conversation in discord.
As one piece of context, it was the nba-pipeline zenfile that originally made me think that the examples wanted beautifying. So I would suggest that (depending on what we end up doing with the examples etc) maybe as a first step for beautifying these individual entities would be to give them the same love and care (emojis, diagrams, clear explanations etc) that you gave the nba-pipeline zenfile? But that of course is pending our bigger decisions about what's happening to the examples in the first place...
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
…io/zenml into feature/ENG-634-beautify-examples
…l with the virtualenv
schustmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small chunk of changes for the Introduction docs section
schustmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developer guide comments
schustmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have some more comments:
- We have a lot of overlap between the sections
stack components,core conceptsandglossary. Do they all have a different scope or can we somehow link to each other to prevent duplicated efforts? - Our "placeholders" in CLI commands are all over the place:
- Some are just uppercase:
zenml stack register STACK_NAME - Some are with dollar signs:
zenml stack register $STACK_NAME(or$stack_name) - Some are with these guys
<>:zenml stack register <STACK_NAME>
I vote for having these unified, with a preference for the last option mainly as gitbook already colors them (<>) differently and therefore makes it easier to detect placeholder values
- Some are just uppercase:
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
schustmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More random comments
…io/zenml into feature/ENG-634-beautify-examples
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
Co-authored-by: Michael Schuster <schustmi@users.noreply.github.com>
…io/zenml into feature/ENG-634-beautify-examples
Describe changes
I have started working on the examples and wanted to check in early to see if this is what you had in mind?
For now I would appreciate just a quick glance without going into detail so that I can know if I'm going into the correct direction.
Pre-requisites
Please ensure you have done the following:
Types of changes