-
Notifications
You must be signed in to change notification settings - Fork 560
FIX: Log a warning instead of raising an AssertionError
#628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AssertionError
strickvl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these suggested fixes, @ketangangal!
Some small changes still on this, since the imports weren't quite correct.
src/zenml/integrations/dash/visualizers/pipeline_run_lineage_visualizer.py
Outdated
Show resolved
Hide resolved
src/zenml/integrations/dash/visualizers/pipeline_run_lineage_visualizer.py
Outdated
Show resolved
Hide resolved
…isualizer.py Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
|
@ketangangal just wanted to let you know that you can just update your PR from within this one. No real need to create a new one. It helps keep all the work that was done in one place. We can then see how things developed as a result of feedback etc. |
|
@strickvl got it thanks correcting mistakes. |
strickvl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing I just remembered from #616 is that the imports should probably be as in my suggested change (i.e. cli_utils.warning and the import change as suggested).
The way you did it before was technically correct, but it just didn't fit how we do it usually in the codebase.
src/zenml/integrations/dash/visualizers/pipeline_run_lineage_visualizer.py
Outdated
Show resolved
Hide resolved
src/zenml/integrations/dash/visualizers/pipeline_run_lineage_visualizer.py
Outdated
Show resolved
Hide resolved
|
@strickvl done ! |
@ketangangal You can see in the CI testing that we have a bunch of failures there. Looking at the error for one of those, it says that the imports are unsorted: I think you didn't run the Poetry linting script as suggested in the |
|
@ketangangal I took the liberty of running the linting script on your behalf. If the tests pass I'll be sure to merge this in. Thank you for your contribution! |
Describe changes
I fixed issue : Log a warning instead of raising an AssertionError
to