Misc bugfixes

examples/github_actions_orchestration/README.md

@@ -48,7 +48,7 @@ zenml orchestrator register github_orchestrator --flavor=github --push=true
 
 # You can find the repository owner and repository name from the URL of your GitHub repository,
 # for example https://github.com/zenml-io/zenml -> The owner would be `zenml-io` and the repository name `zenml`
-zenml secrets_manager register github_secrets_manager \
+zenml secrets-manager register github_secrets_manager \
     --flavor=github \
     --owner=<GITHUB_REPOSITORY_OWNER> \
     --repository=<GITHUB_REPOSITORY_NAME>

src/zenml/cli/secret.py

@@ -23,6 +23,7 @@
 from zenml.cli.utils import (
     confirmation,
     error,
+    expand_argument_value_from_file,
     parse_unknown_options,
     pretty_print_secret,
     print_secrets,
@@ -206,17 +207,22 @@ def register_secret(
             for k in secret_keys:
                 v = getpass.getpass(f"Secret value for {k}:")
                 if v:
-                    secret_contents[k] = v
+                    secret_contents[k] = expand_argument_value_from_file(
+                        name=k, value=v
+                    )
         else:
             click.echo(
                 "You have not supplied a secret schema with any "
                 "predefined keys. Entering interactive mode:"
             )
             while True:
-                k = click.prompt("Please enter a secret-key")
+                k = click.prompt("Please enter a secret key")
                 if k not in secret_contents:
-                    secret_contents[k] = getpass.getpass(
-                        f"Please enter the secret_value for the key [{k}]:"
+                    v = getpass.getpass(
+                        f"Please enter the secret value for the key [{k}]:"
+                    )
+                    secret_contents[k] = expand_argument_value_from_file(
+                        name=k, value=v
                     )
                 else:
                     warning(

src/zenml/cli/stack_components.py

@@ -643,9 +643,13 @@ def update_stack_component_command(
                 else:
                     continue
 
-            updated_component = component_wrapper.to_component().copy(
-                update=parsed_args
-            )
+            # Initialize a new component object to make sure pydantic validation
+            # is used
+            new_attributes = {
+                **component_wrapper.to_component().dict(),
+                **parsed_args,
+            }
+            updated_component = component_class(**new_attributes)
 
             repo.update_stack_component(
                 name, updated_component.TYPE, updated_component
@@ -721,9 +725,13 @@ def remove_attribute_stack_component_command(
                         f"'{', '.join(optional_attributes)}'."
                     )
 
-            updated_component = current_component.copy(
-                update={arg: None for arg in parsed_args}
-            )
+            # Remove the attributes from the current component dict
+            new_attributes = {
+                **current_component.dict(),
+                **{arg: None for arg in parsed_args},
+            }
+
+            updated_component = current_component.__class__(**new_attributes)
 
             repo.update_stack_component(
                 name, updated_component.TYPE, updated_component

src/zenml/cli/utils.py

@@ -497,7 +497,7 @@ def format_date(
 MAX_ARGUMENT_VALUE_SIZE = 10240
 
 
-def _expand_argument_value_from_file(name: str, value: str) -> str:
+def expand_argument_value_from_file(name: str, value: str) -> str:
     """Expands the value of an argument pointing to a file into the contents of that file.
 
     Args:
@@ -519,7 +519,7 @@ def _expand_argument_value_from_file(name: str, value: str) -> str:
         return value[1:]
     if not value.startswith("@"):
         return value
-    filename = value[1:]
+    filename = os.path.abspath(value[1:])
     logger.info(
         f"Expanding argument value `{name}` to contents of file `{filename}`."
     )
@@ -572,7 +572,7 @@ def parse_unknown_options(
 
     if expand_args:
         args_dict = {
-            k: _expand_argument_value_from_file(k, v)
+            k: expand_argument_value_from_file(k, v)
             for k, v in args_dict.items()
         }
 

src/zenml/utils/docker_utils.py

@@ -87,6 +87,8 @@ def generate_dockerfile_contents(
             lines.append(f"ENV {key.upper()}={value}")
 
     if requirements:
+        # Quote the requirements to avoid problems with special characters
+        requirements = {f"'{r}'" for r in requirements}
         lines.append(
             f"RUN pip install --no-cache {' '.join(sorted(requirements))}"
         )