Skip to content

Conversation

@jsuchome
Copy link
Contributor

@jsuchome jsuchome commented Jun 29, 2022

It's '--lr', not '--learning_rate'.

Describe changes

Small fix of README file

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

It's '--lr', not '--learning_rate'.
@CLAassistant
Copy link

CLAassistant commented Jun 29, 2022

CLA assistant check
All committers have signed the CLA.

@htahir1 htahir1 requested a review from strickvl June 29, 2022 14:30
@strickvl strickvl changed the base branch from main to develop June 29, 2022 14:32
@strickvl strickvl added bug Something isn't working documentation Improvements or additions to documentation labels Jun 29, 2022
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for submitting this PR!

@strickvl
Copy link
Contributor

I'll get this merged in whenever you're able to sign the CLA. Thank you!

@strickvl strickvl merged commit 6dc4a02 into zenml-io:develop Jun 30, 2022
SangamSwadiK pushed a commit to SangamSwadiK/zenml that referenced this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants