Skip to content

Node.js,pnpm,lerna-liteをアップデート, パッケージのPublishにOIDC trusted Publishingを設定 #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cm-dyoshikawa merged 3 commits into from
Oct 17, 2025
Merged

Node.js,pnpm,lerna-liteをアップデート, パッケージのPublishにOIDC trusted Publishingを設定 #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebecece
chore: update Node.js and pnpm versions
cm-dyoshikawa Oct 17, 2025
c8fdd07
chore: upgrade lerna-lite to v4.9.0 and add optional commands
cm-dyoshikawa Oct 17, 2025
93aeaac
chore: migrate to OIDC Trusted Publishing for npm releases
cm-dyoshikawa Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- uses: pnpm/action-setup@v4
with:
version: 9
version: 10

- name: パッケージをインストール
run: pnpm install
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/publish-canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,22 @@ jobs:
publish:
name: Publish
runs-on: ubuntu-latest
permissions:
contents: read
id-token: write
Comment on lines +17 to +19
Copy link
Contributor Author

@cm-dyoshikawa cm-dyoshikawa Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OIDC Trusted Publishingで必要な設定
https://github.com/lerna-lite/lerna-lite/tree/main/packages/publish#oidc
https://github.com/lerna-lite-test/oidc/blob/main/.github/workflows/release.yml

steps:
- name: Checkout
uses: actions/checkout@v3

- uses: pnpm/action-setup@v4
with:
version: 9
version: 10

- name: Setup node
uses: actions/setup-node@v4
with:
cache: 'pnpm'
node-version: 18
node-version: 24
registry-url: 'https://registry.npmjs.org'

- name: ビルド時に使用する環境変数を設定
Expand Down Expand Up @@ -72,7 +75,6 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish canary
run: pnpm lerna publish from-package --yes --pre-dist-tag canary
run: pnpm lerna publish from-package --yes --pre-dist-tag canary --provenance
Copy link
Contributor Author

@cm-dyoshikawa cm-dyoshikawa Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--provenance は署名機能（ONが推奨っぽい）

https://zenn.dev/bicstone/articles/npm-provenance
https://docs.npmjs.com/generating-provenance-statements

env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
10 changes: 6 additions & 4 deletions .github/workflows/publish-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,22 @@ jobs:
publish:
name: Publish
runs-on: ubuntu-latest
permissions:
contents: read
id-token: write
steps:
- name: Checkout
uses: actions/checkout@v3

- uses: pnpm/action-setup@v4
with:
version: 9
version: 10

- name: Setup node
uses: actions/setup-node@v4
with:
cache: 'pnpm'
node-version: 18
node-version: 24
registry-url: 'https://registry.npmjs.org'

- name: ビルド時に使用する環境変数を設定
Expand Down Expand Up @@ -72,9 +75,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Publish latest
run: pnpm lerna publish from-package --yes
run: pnpm lerna publish from-package --yes --provenance
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

- uses: pnpm/action-setup@v4
with:
version: 9
version: 10

- name: パッケージをインストール
run: pnpm install
Expand Down
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
{
"private": true,
"devDependencies": {
"@lerna-lite/cli": "^1.15.1",
"@lerna-lite/cli": "^4.9.0",
"@lerna-lite/publish": "^4.9.0",
"@lerna-lite/version": "^4.9.0",
Comment on lines +4 to +6
Copy link
Contributor Author

@cm-dyoshikawa cm-dyoshikawa Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

アップデートで publish と version のパッケージが分離されたので、明示的にインストールが必要

"@secretlint/secretlint-rule-preset-recommend": "^11.2.5",
"npm-run-all": "^4.1.5",
"prettier": "^3.3.3",
Expand Down Expand Up @@ -37,7 +39,7 @@
"engines": {
"npm": "use pnpm please!",
"yarn": "use pnpm please!",
"pnpm": ">=9 <10"
"pnpm": ">=10 <11"
},
"simple-git-hooks": {
"pre-commit": "pnpm secretlint"
Expand Down
2 changes: 1 addition & 1 deletion packages/zenn-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"zenn-model": "workspace:*"
},
"engines": {
"node": ">=14.0.0"
"node": ">=22.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
Loading