This repository was archived by the owner on Feb 14, 2026. It is now read-only.
fix(config): normalize base path handling for skill discovery (closes #27)#32
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #27 by improving skill discovery reliability through better path normalization and clearer diagnostic messages. The changes help users who misconfigure their basePaths by detecting common typos (e.g., "skill" vs "skills") and providing helpful suggestions.
Changes:
- Introduced path normalization functions (
resolveBasePath,normalizeBasePaths) to handle tilde expansion, relative-to-absolute conversion, and deduplication - Added typo detection that suggests "skills" when users configure paths ending in "skill"
- Added unit tests for the new path normalization functions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/config.ts | Adds path normalization functions to resolve, deduplicate, and normalize configured base paths; integrates normalization into getPluginConfig |
| src/services/SkillRegistry.ts | Adds helper functions to detect "skill" vs "skills" typos and provides helpful warning messages when no valid paths are found |
| src/config.test.ts | Adds comprehensive unit tests for new path resolution and normalization functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve skill discovery reliability by normalizing configured base paths and adding clearer diagnostics when no valid skill directories are found.
Linked Artifact
Closes #27
Changes
basePathsto absolute, deduplicated paths resolved from project context.~and handle relative path inputs consistently during config load.skillvsskillstypo cases when discovery finds no valid base path.Testing
bun test src/config.test.ts)