Skip to content
This repository was archived by the owner on Feb 14, 2026. It is now read-only.

fix(config): normalize base path handling for skill discovery (closes #27)#32

Merged
airtonix merged 5 commits into
mainfrom
feature/27
Feb 13, 2026
Merged

fix(config): normalize base path handling for skill discovery (closes #27)#32
airtonix merged 5 commits into
mainfrom
feature/27

Conversation

@airtonix
Copy link
Copy Markdown
Contributor

Summary

Improve skill discovery reliability by normalizing configured base paths and adding clearer diagnostics when no valid skill directories are found.

Linked Artifact

Closes #27

Changes

  • Normalize configured basePaths to absolute, deduplicated paths resolved from project context.
  • Expand ~ and handle relative path inputs consistently during config load.
  • Add warning hints for likely skill vs skills typo cases when discovery finds no valid base path.
  • Add unit tests for base path resolution/normalization behavior.

Testing

  • Unit tests added/passing (bun test src/config.test.ts)
  • Integration tests passing
  • Manual testing completed

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #27 by improving skill discovery reliability through better path normalization and clearer diagnostic messages. The changes help users who misconfigure their basePaths by detecting common typos (e.g., "skill" vs "skills") and providing helpful suggestions.

Changes:

  • Introduced path normalization functions (resolveBasePath, normalizeBasePaths) to handle tilde expansion, relative-to-absolute conversion, and deduplication
  • Added typo detection that suggests "skills" when users configure paths ending in "skill"
  • Added unit tests for the new path normalization functions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/config.ts Adds path normalization functions to resolve, deduplicate, and normalize configured base paths; integrates normalization into getPluginConfig
src/services/SkillRegistry.ts Adds helper functions to detect "skill" vs "skills" typos and provides helpful warning messages when no valid paths are found
src/config.test.ts Adds comprehensive unit tests for new path resolution and normalization functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/services/SkillRegistry.ts Outdated
Comment thread src/config.test.ts
Comment thread src/services/SkillRegistry.ts
Comment thread src/services/SkillRegistry.ts Outdated
@airtonix airtonix merged commit ef8f0cd into main Feb 13, 2026
2 checks passed
@airtonix airtonix deleted the feature/27 branch February 13, 2026 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: No valid base paths found for skill discovery:

2 participants