"module" -> "default" #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Updated to add a clause to note using "module" could be a possibility subject to compatibility testing. |
Owner
|
I tend to agree, and feel pretty good about "default" in |
Closed
Contributor
Author
|
@zenparsing do you also agree here that if we test this implementation with "module" in place of "default" and it works out in some wide initial testing, "module" can still be considered? |
Owner
|
I agree. Both "module" and "default" seem acceptable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #18 it may make more sense to double-down on a unique main property if we can't guarantee that automatic file extension adding will be included for the ES resolver.
It just seems to hinge on too many compatibility decisions to assume this will work out at this stage. If it does work out eventually, great though. But let's not make bets.