-
Notifications
You must be signed in to change notification settings - Fork 0
docs: Transactions Filters & Grouping — Phase B design (draft) #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce.share/shareXFiles in QR + ShareService; remove local stub
…hare_plus directly
…g and DeleteFamilyDialog
…or) + fix const-eval in common widgets
…pture and fix duplicates
…ignores; fix template onCancel and batch dialogs snackbars
…vigator capture and mounted guards
…rs (accounts/dashboard types, const-eval, family settings void, email Address stub); wire A/B/C entrances
…oup toggle in TransactionList; optional filter icon in RecentTransactions
…sactions; finalize TransactionList search bar impl
- Fixed lines 180 and 183 which had ASCII SOH (0x01) control characters - Added proper parameters to updateFamilySettings and deleteFamilySettings calls - Now uses change.entityId and change.data! as required by the API methods Fixes build_runner failure: 'Illegal character 1' at lines 180:57 and 183:57
zensgit
added a commit
that referenced
this pull request
Oct 8, 2025
Resolved git merge conflicts that were polluting all feature branches: - theme_management_screen.dart: 5 conflicts (ScaffoldMessenger patterns) - transaction_provider.dart: 2 conflicts (duplicate enum & method definitions) - family_activity_log_screen.dart: 1 conflict (statistics loading) All conflicts resolved by: - Preferring messenger variable pattern over repeated ScaffoldMessenger.of() - Removing duplicate enum and method definitions - Using direct stats return instead of _parseActivityStatistics() Added comprehensive PR fix report documenting all 5 PRs analyzed. This fix will automatically benefit all PRs (#65, #66, #68, #69, #70) as they rebase/merge from main. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved 15 file conflicts by accepting main's clean version. Same pattern as PR #65 - duplicate variable declarations removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design proposal for Phase B: filters (text/date/type/account/category/tag/amount), grouping (date/category/account) with subtotals, provider/state changes, and phased rollout.