feat: Travel Mode MVP #70
Conversation
…nce.share/shareXFiles in QR + ShareService; remove local stub
…hare_plus directly
…g and DeleteFamilyDialog
…or) + fix const-eval in common widgets
…pture and fix duplicates
…ignores; fix template onCancel and batch dialogs snackbars
…vigator capture and mounted guards
…rs (accounts/dashboard types, const-eval, family settings void, email Address stub); wire A/B/C entrances
…oup toggle in TransactionList; optional filter icon in RecentTransactions
…sactions; finalize TransactionList search bar impl
…onFilter); prune TransactionStats fields
…roup controls (Phase B1 UI)
…s; add controller persistence unit test
…on-date as flat for now
… headers; respect provider grouping; fix duplicate map in date view
…g testable and re-enable widget test
- Add travel domain models and types - Create travel service with business logic - Add travel API handlers and routes - Create database tables (travel_events, travel_transactions, travel_budgets) - Support multi-currency, budgets by category, transaction linking - Implement travel lifecycle (Planning → Active → Completed) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello @zensgit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers the Minimum Viable Product (MVP) for a 'Travel Mode' feature, significantly expanding the application's financial management capabilities. It encompasses extensive backend development to support travel event and budget management, alongside substantial frontend updates to integrate these new features and enhance existing UI elements. The changes also include important code quality improvements and refactoring in the Flutter application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements the Travel Mode MVP feature for Jive Money, adding comprehensive travel planning and expense tracking capabilities. The implementation includes core domain models, application services, API endpoints, and supporting database infrastructure for multi-currency travel budget management and transaction tracking.
Key changes:
- Added complete travel domain model with lifecycle management (planning → active → completed)
- Implemented travel service with CRUD operations, transaction association, and statistics
- Created 11 REST API endpoints for travel event management
- Added database migration with 3 tables and supporting functions
Reviewed Changes
Copilot reviewed 60 out of 64 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| jive-core/src/domain/travel.rs | Core travel domain model with entities, validation, and business logic |
| jive-core/src/application/travel_service.rs | Application service implementing travel management operations |
| jive-api/src/handlers/travel.rs | REST API handlers for travel endpoints |
| jive-api/migrations/038_add_travel_mode_mvp.sql | Database schema for travel tables and functions |
| Multiple test files | Unit tests for transaction grouping and controller functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| .bind(input.total_budget) | ||
| .bind(input.budget_currency_id) | ||
| .bind(input.home_currency_id) |
There was a problem hiding this comment.
The field names in the domain model don't match the database column names being used in the SQL query. The input uses budget_currency_code and home_currency_code (String) but the SQL binds to budget_currency_id and home_currency_id (UUID). This will cause type mismatches and runtime errors.
| if let Some(budget_currency_id) = input.budget_currency_id { | ||
| event.budget_currency_id = Some(budget_currency_id); |
There was a problem hiding this comment.
Same issue as in create - the field names don't match. The UpdateTravelEventInput likely has budget_currency_code but this code expects budget_currency_id.
| if let Some(budget_currency_id) = input.budget_currency_id { | |
| event.budget_currency_id = Some(budget_currency_id); | |
| if let Some(budget_currency_code) = input.budget_currency_code { | |
| // Lookup currency ID by code | |
| let rec = sqlx::query!( | |
| "SELECT id FROM currencies WHERE code = $1", | |
| budget_currency_code | |
| ) | |
| .fetch_optional(&self.pool) | |
| .await?; | |
| if let Some(row) = rec { | |
| event.budget_currency_id = Some(row.id); | |
| } else { | |
| return Err(JiveError::InvalidInput(format!("Currency code '{}' not found", budget_currency_code))); | |
| } |
jive-api/src/handlers/travel.rs
Outdated
| .bind(input.budget_currency_id) | ||
| .bind(input.home_currency_id) |
There was a problem hiding this comment.
Inconsistency between the domain model field names (budget_currency_code, home_currency_code) and the API handler usage (budget_currency_id, home_currency_id). This will cause compilation errors or unexpected behavior.
| .bind(input.budget_currency_id) | |
| .bind(input.home_currency_id) | |
| .bind(input.budget_currency_code) | |
| .bind(input.home_currency_code) |
| pub budget_currency_code: Option<String>, | ||
| pub home_currency_code: String, |
There was a problem hiding this comment.
The domain model uses budget_currency_code and home_currency_code as String fields, but the database schema and service layer expect UUID foreign keys to the currencies table. This creates a type mismatch that will prevent the code from compiling or working correctly.
| pub budget_currency_code: Option<String>, | |
| pub home_currency_code: String, | |
| pub budget_currency_id: Option<Uuid>, | |
| pub home_currency_id: Uuid, |
| GRANT ALL ON travel_events TO jive_user; | ||
| GRANT ALL ON travel_transactions TO jive_user; | ||
| GRANT ALL ON travel_budgets TO jive_user; |
There was a problem hiding this comment.
Granting ALL permissions on tables is overly permissive. Consider granting only the specific permissions needed (SELECT, INSERT, UPDATE, DELETE) instead of ALL to follow the principle of least privilege.
| GRANT ALL ON travel_events TO jive_user; | |
| GRANT ALL ON travel_transactions TO jive_user; | |
| GRANT ALL ON travel_budgets TO jive_user; | |
| GRANT SELECT, INSERT, UPDATE, DELETE ON travel_events TO jive_user; | |
| GRANT SELECT, INSERT, UPDATE, DELETE ON travel_transactions TO jive_user; | |
| GRANT SELECT, INSERT, UPDATE, DELETE ON travel_budgets TO jive_user; |
| void main() { | ||
| TestWidgetsFlutterBinding.ensureInitialized(); | ||
|
|
||
| group('TransactionList grouping widget', () { | ||
| testWidgets('category grouping renders and collapses', (tester) async { | ||
| final transactions = <Transaction>[ | ||
| Transaction( | ||
| id: 't1', | ||
| type: TransactionType.expense, | ||
| amount: 12.34, | ||
| description: 'Lunch', | ||
| category: '餐饮', | ||
| date: DateTime.now(), | ||
| ), | ||
| Transaction( | ||
| id: 't2', | ||
| type: TransactionType.expense, | ||
| amount: 20, | ||
| description: 'Dinner', | ||
| category: '餐饮', | ||
| date: DateTime.now(), | ||
| ), | ||
| Transaction( | ||
| id: 't3', | ||
| type: TransactionType.income, | ||
| amount: 100, | ||
| description: 'Salary', | ||
| category: '工资', | ||
| date: DateTime.now(), |
There was a problem hiding this comment.
[nitpick] The test uses hardcoded test data with magic values. Consider extracting the test transaction creation into a helper method or using a test data builder pattern to improve maintainability and reduce duplication.
| void main() { | |
| TestWidgetsFlutterBinding.ensureInitialized(); | |
| group('TransactionList grouping widget', () { | |
| testWidgets('category grouping renders and collapses', (tester) async { | |
| final transactions = <Transaction>[ | |
| Transaction( | |
| id: 't1', | |
| type: TransactionType.expense, | |
| amount: 12.34, | |
| description: 'Lunch', | |
| category: '餐饮', | |
| date: DateTime.now(), | |
| ), | |
| Transaction( | |
| id: 't2', | |
| type: TransactionType.expense, | |
| amount: 20, | |
| description: 'Dinner', | |
| category: '餐饮', | |
| date: DateTime.now(), | |
| ), | |
| Transaction( | |
| id: 't3', | |
| type: TransactionType.income, | |
| amount: 100, | |
| description: 'Salary', | |
| category: '工资', | |
| date: DateTime.now(), | |
| // Helper to create test transactions with sensible defaults | |
| Transaction testTransaction({ | |
| required String id, | |
| required TransactionType type, | |
| required double amount, | |
| required String description, | |
| required String category, | |
| DateTime? date, | |
| }) { | |
| return Transaction( | |
| id: id, | |
| type: type, | |
| amount: amount, | |
| description: description, | |
| category: category, | |
| date: date ?? DateTime.now(), | |
| ); | |
| } | |
| void main() { | |
| TestWidgetsFlutterBinding.ensureInitialized(); | |
| group('TransactionList grouping widget', () { | |
| testWidgets('category grouping renders and collapses', (tester) async { | |
| final transactions = <Transaction>[ | |
| testTransaction( | |
| id: 't1', | |
| type: TransactionType.expense, | |
| amount: 12.34, | |
| description: 'Lunch', | |
| category: '餐饮', | |
| ), | |
| testTransaction( | |
| id: 't2', | |
| type: TransactionType.expense, | |
| amount: 20, | |
| description: 'Dinner', | |
| category: '餐饮', | |
| ), | |
| testTransaction( | |
| id: 't3', | |
| type: TransactionType.income, | |
| amount: 100, | |
| description: 'Salary', | |
| category: '工资', |
| // 统一为文字分享，图像功能暂时关闭 | ||
| await Share.share(shareText); |
There was a problem hiding this comment.
[nitpick] The image sharing functionality has been commented out with a TODO-style comment. Consider using a proper feature flag or configuration parameter instead of hardcoded comment to control this behavior.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
这个 PR 实现了旅行模式的 MVP 版本，包含了后端的数据库、领域模型、应用服务和 API 端点，以及前端的一些准备工作，非常完整。代码结构清晰，后端逻辑大部分都比较完善。
我发现了一些需要注意的问题，主要集中在后端的性能和安全方面：
- 数据库迁移脚本中的触发器和函数存在性能隐患，尤其是在批量操作时。
- API 处理器中有 SQL 注入的风险，以及一个严重的数据类型转换错误，可能导致运行时恐慌或数据错误。
- 领域模型和 API 输入模型之间存在字段类型不匹配的问题，会导致编译失败。
前端方面，大部分改动是重构和优化，但也发现一处实现与设计文档不符的地方。
具体的修改建议请看下面的评论。
| if let Some(start_date) = filter.start_date { | ||
| query.push_str(&format!(" AND date >= '{}'", start_date)); | ||
| } | ||
| if let Some(end_date) = filter.end_date { | ||
| query.push_str(&format!(" AND date <= '{}'", end_date)); |
There was a problem hiding this comment.
在 attach_transactions 函数中，构建用于过滤交易的 SQL 查询时，直接使用了 format! 宏来拼接日期字符串。这是一个严重的安全隐患，可能导致 SQL 注入。
虽然 NaiveDate 的 to_string() 目前可能是安全的，但这是一种非常危险的实践。应该始终使用查询参数来绑定值。
建议修改为使用 sqlx 的查询参数绑定。
jive-api/src/handlers/travel.rs
Outdated
|
|
||
| let total = event.total_spent; | ||
| let categories: Vec<CategorySpending> = category_spending.into_iter().map(|row| { | ||
| let amount = Decimal::from_i64_retain(row.amount.unwrap_or(0)).unwrap_or_default(); |
There was a problem hiding this comment.
在 get_travel_statistics 函数中，处理从数据库返回的 amount 时存在严重的数据类型转换错误。
sqlx::query! 宏在 SUM(t.amount) 后返回的 amount 类型应该是 Option<Decimal>。然而，代码中使用了 Decimal::from_i64_retain(row.amount.unwrap_or(0))，这会尝试将 Decimal 当作 i64 来处理，这是不正确的，并且可能会导致运行时 panic 或严重的数据计算错误。
正确的处理方式应该是直接使用 Decimal 类型。
| let amount = Decimal::from_i64_retain(row.amount.unwrap_or(0)).unwrap_or_default(); | |
| let amount = row.amount.unwrap_or_default(); |
| if let Some(start_date) = filter.start_date { | ||
| query.push_str(&format!(" AND date >= '{}'", start_date)); | ||
| } | ||
| if let Some(end_date) = filter.end_date { | ||
| query.push_str(&format!(" AND date <= '{}'", end_date)); |
There was a problem hiding this comment.
在 attach_transactions 函数中，构建 SQL 查询时直接拼接了日期字符串，这存在 SQL 注入的风险。
与 handlers/travel.rs 中的问题类似，应使用查询参数绑定来代替字符串格式化。
建议修改为使用 sqlx 的参数化查询来避免此安全漏洞。
|
|
||
| let total = event.total_spent; | ||
| let categories = category_spending.into_iter().map(|row| { | ||
| let amount = rust_decimal::Decimal::from_i64_retain(row.amount.unwrap_or(0)).unwrap_or_default(); |
There was a problem hiding this comment.
在 get_travel_statistics 函数中，处理从数据库返回的 amount 时存在严重的数据类型转换错误。
sqlx::query! 宏在 SUM(t.amount) 后返回的 amount 类型应该是 Option<Decimal>。然而，代码中使用了 rust_decimal::Decimal::from_i64_retain(row.amount.unwrap_or(0))，这会尝试将 Decimal 当作 i64 来处理，这是不正确的，并且可能会导致运行时 panic 或严重的数据计算错误。
正确的处理方式应该是直接使用 Decimal 类型。
| let amount = rust_decimal::Decimal::from_i64_retain(row.amount.unwrap_or(0)).unwrap_or_default(); | |
| let amount = rust_decimal::Decimal::from(row.amount.unwrap_or(0)); |
| pub struct CreateTravelEventInput { | ||
| pub trip_name: String, | ||
| pub start_date: NaiveDate, | ||
| pub end_date: NaiveDate, | ||
| pub total_budget: Option<Decimal>, | ||
| pub budget_currency_code: Option<String>, | ||
| pub home_currency_code: String, | ||
| pub settings: Option<TravelSettings>, | ||
| } |
There was a problem hiding this comment.
在 CreateTravelEventInput 结构体中，货币字段被定义为 budget_currency_code: Option<String> 和 home_currency_code: String。
然而，在 jive-api/src/handlers/travel.rs 的 create_travel_event 处理器中，代码尝试访问 input.budget_currency_id 和 input.home_currency_id，这些字段在该结构体中并不存在。这会导致编译错误。
请统一 API 输入模型和领域模型中的字段名称和类型。建议 API 接收 ..._code (字符串)，然后在服务层或处理器中查询 currencies 表将其转换为 ..._id (UUID) 再存入数据库。
| - Phase C（另案）：增量新增 `/transactions/search` 支持字段与分页；Rust 侧生成 SQLx 查询 + .sqlx 更新。 | ||
|
|
||
| Persistence | ||
| - SharedPreferences key: `tx_ui_<ledgerId>_{query,grouping}`； |
There was a problem hiding this comment.
持久化键的格式 tx_ui_<ledgerId>_{query,grouping} 有些模糊。这代表一个键还是两个键？
如果它代表两个独立的键，建议明确写为 tx_ui_<ledgerId>_query 和 tx_ui_<ledgerId>_grouping。
如果它代表一个组合键，其值是一个包含 query 和 grouping 的 JSON 对象，也建议在文档中说明。明确的格式定义有助于避免前端实现时的歧义。
|
|
||
| -- Basic information | ||
| trip_name VARCHAR(100) NOT NULL, | ||
| status VARCHAR(20) DEFAULT 'planning' CHECK (status IN ('planning', 'active', 'completed', 'cancelled')), |
There was a problem hiding this comment.
建议将 status 字段的类型从 VARCHAR(20) 改为自定义的 ENUM 类型，例如 CREATE TYPE travel_status AS ENUM ('planning', 'active', 'completed', 'cancelled');。使用 ENUM 类型可以提供更好的类型安全性和数据一致性，并且在存储和查询效率上也可能更有优势。
|
|
||
| -- Budget amount (inherits currency from travel_event) | ||
| budget_amount DECIMAL(15,2) NOT NULL, | ||
| budget_currency_id UUID REFERENCES currencies(id), |
There was a problem hiding this comment.
在 travel_budgets 表中，budget_currency_id 字段似乎是多余的。根据第72行的注释 --(inherits currency from travel_event)，预算的货币单位继承自旅行事件。如果该字段总是和 travel_events 表中的 budget_currency_id 保持一致，建议移除此字段以避免数据冗余和潜在的不一致。如果它允许覆盖父事件的货币，那么注释则有误导性，需要更新。
| pub id: Uuid, | ||
| pub family_id: Uuid, | ||
| pub trip_name: String, | ||
| pub status: String, |
There was a problem hiding this comment.
为了增强类型安全，建议将 TravelEvent 结构体中的 status 字段从 String 类型改为在 jive_core::domain 中定义的 TravelStatus 枚举。
这样可以利用 Rust 的类型系统在编译时就防止无效状态的出现，并使代码更清晰。你可以使用 #[serde(with = "...")] 或自定义的 From 和 Into 实现来处理与数据库字符串之间的转换。
| final groupingStr = prefs.getString("tx_grouping"); | ||
| TransactionGrouping grouping = state.grouping; | ||
| if (groupingStr != null) { | ||
| grouping = TransactionGrouping.values.firstWhere( | ||
| (g) => g.name == groupingStr, | ||
| orElse: () => TransactionGrouping.date, | ||
| ); | ||
| } | ||
| final collapsedList = | ||
| prefs.getStringList("tx_group_collapse") ?? const <String>[]; | ||
| if (grouping != state.grouping || | ||
| collapsedList.length != state.groupCollapse.length) { | ||
| state = state.copyWith( | ||
| grouping: grouping, | ||
| groupCollapse: collapsedList.toSet(), | ||
| ); | ||
| } | ||
| } catch (_) { | ||
| // Ignore persistence errors | ||
| } | ||
| } | ||
|
|
||
| Future<void> _persistGrouping() async { | ||
| try { | ||
| final prefs = await SharedPreferences.getInstance(); | ||
| await prefs.setString("tx_grouping", state.grouping.name); | ||
| } catch (_) {} | ||
| } | ||
|
|
||
| Future<void> _persistGroupCollapse(Set<String> collapsed) async { | ||
| try { | ||
| final prefs = await SharedPreferences.getInstance(); | ||
| await prefs.setStringList("tx_group_collapse", collapsed.toList()); |
There was a problem hiding this comment.
这里的视图偏好设置（分组方式、折叠状态）的持久化键是全局的（例如 "tx_grouping"），而不是按账本区分的。
根据设计文档 FEATURE_TX_FILTERS_GROUPING.md 中的定义，这些设置应该是 per-ledger 的，键格式为 tx_ui_<ledgerId>_{query,grouping}。
当前的实现会导致所有账本共享相同的视图设置，这与设计不符。建议修改持久化逻辑，将 ledgerId 作为键的一部分，为每个账本独立保存视图偏好。
…r new controller Ref constructor
- Created missing Travel Mode files (TravelProvider, TravelService, TravelListScreen) - Added missing apiServiceProvider - Fixed TravelEvent model to include budget, currency, and status fields - Fixed syntax errors in family_settings_service.dart (removed illegal characters) - Fixed class structure in transaction_list.dart - Resolved merge conflicts from previous stashed changes - Successfully ran Freezed code generation All Travel Mode related compilation errors have been resolved.
Document all fixes and changes made to resolve Travel Mode compilation errors
Resolved git merge conflicts that were polluting all feature branches: - theme_management_screen.dart: 5 conflicts (ScaffoldMessenger patterns) - transaction_provider.dart: 2 conflicts (duplicate enum & method definitions) - family_activity_log_screen.dart: 1 conflict (statistics loading) All conflicts resolved by: - Preferring messenger variable pattern over repeated ScaffoldMessenger.of() - Removing duplicate enum and method definitions - Using direct stats return instead of _parseActivityStatistics() Added comprehensive PR fix report documenting all 5 PRs analyzed. This fix will automatically benefit all PRs (#65, #66, #68, #69, #70) as they rebase/merge from main. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved 24 files with conflicts: - Common files: Accepted main's messenger/navigator pattern - Travel files: Accepted main's budget schema (totalBudget, budgetCurrencyCode, etc.) - Test files: Accepted main's updated test pattern - All conflicts resolved using --theirs (main branch) strategy
- Remove duplicate CreateTravelEventInput class in travel_create_dialog.dart - Fix statistics nullable access in travel_detail_screen.dart - Use non-null assertion operator after null check for public property
📋 合并main分支更新报告✅ 已完成
❌ CI测试失败
🔍 需要进一步调查测试失败可能与Travel Mode功能本身有关，建议：
PR已标记为Draft状态，待问题解决后可重新标记为Ready。 |
- Create TravelEditScreen for adding/editing travel events - Update TravelDetailScreen to use flutter_riverpod - Update TravelListScreen with navigation to edit/detail screens - Add complete CRUD operations for travel events - Implement budget progress tracking - Add transaction statistics display 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove old apiServiceProvider references - Clean up unused imports - Let TravelListScreen handle its own provider initialization - Fix compilation errors in app_router.dart 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Document all completed features - List known issues and next steps - Confirm branch status and recovery from main - Provide testing suggestions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Implemented transaction linking functionality - Added comprehensive budget management screen - Created statistics widget with charts (pie chart, line chart) - Enhanced travel detail screen with budget and statistics - Created custom UI components (TextField, Button) - Fixed all compilation errors and model issues - Added 14 unit tests (all passing) Features completed: ✅ Transaction-Travel linking with batch selection ✅ Budget management (total and category-based) ✅ Statistics visualization (spending by category, daily trends) ✅ Top expenses tracking ✅ Multi-currency support ✅ Complete CRUD operations ✅ Responsive UI with real-time updates Closes #travel-mode-mvp
- 创建TravelExportService服务类处理多格式导出 - 支持CSV格式导出（Excel兼容） - 支持HTML格式导出（可打印和转PDF） - 支持JSON格式导出（结构化数据） - 在详情页添加导出菜单按钮 - 集成系统分享功能 - 包含完整的旅行数据、预算、交易和统计信息 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
✨ 新增功能: - 创建TravelPhotoGalleryScreen照片管理界面 - 支持拍照和从相册选择照片（单张/多张） - 照片网格视图和列表视图切换 - 全屏查看照片，支持缩放和滑动浏览 - 本地存储照片到应用文档目录 - 照片删除功能和确认对话框 - 在详情页添加照片入口按钮 🧪 测试: - 添加完整的导出功能单元测试（19个测试） - 测试CSV、HTML、JSON格式生成逻辑 - 测试分类统计、预算计算等核心功能 - 所有测试通过 📦 依赖: - 添加path包用于文件路径处理 - 使用image_picker包进行照片选择 🐛 修复: - 修复SharePlus API调用错误 - 修复CurrencyFormatter测试期望值 - 修复withOpacity废弃方法警告 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
📋 报告内容: - 导出功能实现总结 - 照片管理功能总结 - 测试完善情况 - 功能完成度统计 - 下一步计划 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
## Rust API Fixes ### Currency Schema Mismatch (src/handlers/travel.rs) - Changed currency fields from `Uuid` to `String` (ISO 4217 codes) - Updated 5 structures: CreateTravelEventInput, UpdateTravelEventInput, TravelEvent, TravelBudget, UpsertTravelBudgetInput - Modified 4 SQL queries to use `*_currency_code` instead of `*_currency_id` - Fixed statistics query to join through ledgers table for family_id filtering ### Error Handling (src/error.rs) - Added `From<sqlx::Error>` trait implementation - Removed dependency on non-existent jive_core crate - Fixed InternalError variant usage ### Testing - Created comprehensive CRUD test script (test_travel_api.sh) - All 6 Travel API operations tested: 100% pass rate - Updated test data to use ISO currency codes (JPY, CNY) ## Flutter Fixes ### travel_transaction_link_screen.dart 1. Fixed provider reference (line 45) - Changed from undefined `transactionNotifierProvider` - To correct `transactionControllerProvider` 2. Fixed CheckboxListTile widget (line 256) - Replaced CheckboxListTile with custom ListTile + Checkbox - Moved CheckboxListTile `secondary` content to title Row - Kept `trailing` parameter for amount/tags display ## Documentation - Added 4 comprehensive fix reports - API_INTEGRATION_TEST_REPORT.md (10/10 tests passing) - BACKEND_API_FIX_REPORT.md - LOGIN_FIX_REPORT.md (Argon2 password fix) - TRAVEL_API_SCHEMA_FIX_REPORT.md (complete schema fix details) ## Test Results - ✅ Rust API: All compilation errors resolved - ✅ Flutter: All syntax errors fixed - ✅ Travel CRUD: 100% test pass (6/6 operations) - ✅ Authentication: Login working with JWT tokens 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
## SQLx Offline Cache Updates - Regenerated .sqlx/ cache files for all modified queries - Updated cache for travel.rs currency field changes (Uuid → String) - Updated cache for accounts.rs bank_id column addition ## Currency Service Fixes - Fixed `row.symbol` type error (String, not Option<String>) - Fixed `settings.base_currency` type error (String, not Option<String>) - Removed incorrect .unwrap_or_default() and .unwrap_or_else() calls ## Database Changes Applied - Ran migration 032_add_bank_id_to_accounts.sql - Added bank_id UUID column to accounts table - Created index on accounts.bank_id 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed SQLx offline cache mismatch detected in CI by: 1. Database Schema Corrections: - Made currencies.symbol nullable (per migration 011) - Changed currencies.flag from VARCHAR to TEXT type - Made family_currency_settings.base_currency nullable 2. Code Adjustments: - Updated currency_service.rs to handle nullable symbol/base_currency - Added .unwrap_or_default() for symbol (defaults to empty string) - Added .unwrap_or_else(|| "CNY") for base_currency 3. SQLx Cache Updates: - Regenerated .sqlx/*.json files to match corrected schema - Fixed 3 query cache files with nullable/type mismatches Root Cause: Local database schema had drifted from migration definitions. CI builds database fresh from migrations, exposing the mismatch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed Clippy warning `needless_borrows_for_generic_args` in travel.rs:204. Changed: - serde_json::to_value(&input.settings.unwrap_or_default()) + serde_json::to_value(input.settings.unwrap_or_default()) The borrowed expression implements the required traits, so the reference is unnecessary. This was causing CI to fail in "Check code (SQLx offline)" step. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 participant
Summary
实现旅行模式 MVP 功能，支持多币种旅行预算管理和交易跟踪。
Features
Technical Details
travel_events,travel_transactions,travel_budgetsAPI Endpoints
GET /api/v1/travel/events- 获取旅行列表POST /api/v1/travel/events- 创建新旅行GET /api/v1/travel/events/{id}- 获取旅行详情PUT /api/v1/travel/events/{id}- 更新旅行信息DELETE /api/v1/travel/events/{id}- 删除旅行POST /api/v1/travel/events/{id}/activate- 激活旅行POST /api/v1/travel/events/{id}/complete- 完成旅行POST /api/v1/travel/events/{id}/transactions- 关联交易GET /api/v1/travel/events/{id}/statistics- 获取统计Next Steps
🤖 Generated with Claude Code