-
-
Notifications
You must be signed in to change notification settings - Fork 37
docs: nestjs guide for v3 #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdates multiple documentation submodule pointers, changes dialect import paths in v3 docs to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
versioned_docs/version-3.x/recipe/databases/_category_.ymlis excluded by!**/*.yml
📒 Files selected for processing (13)
code-repos/zenstackhq/v3-doc-orm(1 hunks)code-repos/zenstackhq/v3-doc-orm-computed-fields(1 hunks)code-repos/zenstackhq/v3-doc-orm-policy(1 hunks)code-repos/zenstackhq/v3-doc-orm-polymorphism(1 hunks)code-repos/zenstackhq/v3-doc-orm-typed-json(1 hunks)code-repos/zenstackhq/v3-doc-orm-validation(1 hunks)code-repos/zenstackhq/v3-doc-quick-start(1 hunks)code-repos/zenstackhq/v3-doc-server-adapter(1 hunks)code-repos/zenstackhq/v3-doc-tanstack-query(1 hunks)versioned_docs/version-3.x/migrate-prisma.md(2 hunks)versioned_docs/version-3.x/orm/client.md(2 hunks)versioned_docs/version-3.x/recipe/nestjs.md(1 hunks)versioned_docs/version-3.x/recipe/postgres-multi-schema.md(1 hunks)
🔇 Additional comments (14)
code-repos/zenstackhq/v3-doc-tanstack-query (1)
1-1: Submodule pointer update.This is a routine submodule reference update pointing to a newer commit. Without access to the submodule repository itself, detailed code review of the commit pointer is not applicable. Ensure the submodule update aligns with the PR objectives and that all dependencies and documentation remain consistent.
code-repos/zenstackhq/v3-doc-orm-validation (1)
1-1: Submodule batch update — consistent across all nine v3-doc- repositories.*This PR updates all nine v3-doc-* submodules in a single commit. The v3-doc-orm-validation pointer changes from
42aa1d6to20014ef, alongside parallel updates to orm, orm-computed-fields, orm-policy, orm-polymorphism, orm-typed-json, quick-start, server-adapter, and tanstack-query. Batching submodule updates this way is the right approach and keeps the documentation repositories in sync. The commit message "docs: nestjs guide for v3" aligns with the stated purpose of these changes.code-repos/zenstackhq/v3-doc-orm-policy (1)
1-1: Submodule pointer update aligns with PR objectives.This commit pointer update is part of the coordinated documentation refresh for the v3 NestJS guide. The change is consistent with the other submodule updates mentioned in the PR summary.
code-repos/zenstackhq/v3-doc-server-adapter (1)
1-1: Remove unverifiable speculative claims and provide actionable feedback only if concrete issues can be identified.The review cannot reliably verify the submodule commit or broader PR scope without direct access to the repository or complete PR context. Reframe any feedback to focus only on observable facts: this is a submodule pointer update in the v3-doc-server-adapter repository that aligns with documentation maintenance work mentioned in the PR summary.
versioned_docs/version-3.x/recipe/postgres-multi-schema.md (1)
2-2: Sidebar position update looks good.The change to reorder this recipe to position 3 aligns with the PR objective of adding a NestJS guide. The existing content is accurate and well-structured.
code-repos/zenstackhq/v3-doc-orm-computed-fields (1)
1-1: Submodule pointer update looks good.This is a routine documentation submodule commit reference update, consistent with other coordinated updates in the PR for v3 documentation. No code review concerns apply to Git submodule pointer changes.
code-repos/zenstackhq/v3-doc-orm-polymorphism (1)
1-1: Submodule pointer updated; verify intended documentation changes are included.This change updates the submodule pointer to a new commit. However, the substantive documentation changes (NestJS guide, import path updates, sidebar adjustments) exist in the referenced submodule repository and cannot be assessed from the pointer reference alone.
Confirm that commit
3ef64e7d2a66d8bdfbf3c0ad379f4db9fea0aac1in thezenstackhq/v3-doc-orm-polymorphismrepository includes all intended changes described in the PR objectives.code-repos/zenstackhq/v3-doc-orm (1)
1-1: Submodule update is consistent with PR objective.This change updates the
v3-doc-ormdocumentation submodule pointer for the NestJS guide additions. The update aligns with ZenStack's documented NestJS integration support. Ensure related documentation changes have been merged to the submodule repository before merging this PR.code-repos/zenstackhq/v3-doc-quick-start (1)
1-1: Submodule update to ZenStack V3 documentation is reasonable but cannot be fully verified in isolation.The submodule pointer update to commit
64d688f0b0908a5526e88eae5015a5615023fe3dis consistent with ZenStack V3's documented architectural changes (Kysely-based ORM engine replacing Prisma) and the addition of NestJS integration guides. However, the actual content changes within the submodule cannot be reviewed from the diff alone. The update aligns with the broader ZenStack V3 initiative to replace Prisma with a Kysely-based ORM implementation while maintaining API compatibility.Verify that:
- The submodule commit exists and is reachable in the remote repository
- The documentation builds successfully after the update
code-repos/zenstackhq/v3-doc-orm-typed-json (1)
1-1: Submodule pointer update looks good.Routine update to the latest commit of the v3-doc-orm-typed-json documentation submodule as part of the broader submodule maintenance effort.
versioned_docs/version-3.x/recipe/nestjs.md (2)
1-61: Plain ORM section is well-structured.The examples demonstrate proper DbService extension, module registration, and controller injection. All imports are correctly sourced from
@zenstackhq/ormpackages.
63-123: Verify plugin chaining API on line 97.The code chains
db.$use(new PolicyPlugin()).$setAuth(user)to apply access control. Confirm that the$use()method returns an object with a$setAuth()method as documented in the ZenStack API.versioned_docs/version-3.x/orm/client.md (1)
27-59: Import path updates are correct and consistent.The dialect imports have been updated to use the ZenStack ORM dialect packages (
@zenstackhq/orm/dialects/*) instead of Kysely. The usage patterns in the examples remain correct and unchanged.versioned_docs/version-3.x/migrate-prisma.md (1)
87-122: Import path updates are consistent with other documentation.The dialect imports have been updated to
@zenstackhq/orm/dialects/*packages in both PostgreSQL and SQLite examples. The initialization code remains correct and unchanged.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.