chore(tanstack): add an extra export

[ymc9]

Summary by CodeRabbit

• New Features
  • The FetchFn type is now publicly exported from the TanStack Query client package and available for import in your projects. This API expansion enables developers to access type definitions for enhanced type safety and improved integration when working with the client.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

A public re-export of the FetchFn type is added to the TanStack Query React client package, extending the public API surface without modifying runtime logic or control flow.

Changes

Cohort / File(s)	Summary
Type Export Addition packages/clients/tanstack-query/src/react.ts	Added public re-export: export type { FetchFn } from './utils/common' to expose the FetchFn type through the main entry point

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A tiny hop, a type exposed,
Through re-export gates now unclosed,
FetchFn hops into the light,
The API grows—all is right! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/react-export

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf2ab4b and b94b8e9.

📒 Files selected for processing (1)

• packages/clients/tanstack-query/src/react.ts (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Claude finished @ymc9's task —— View job

---

Code Review for PR #361: chore(tanstack): add an extra export

Review Checklist:

• Analyze the changed file and understand what export was added
• Evaluate code quality and best practices
• Check for potential bugs or issues
• Assess performance considerations
• Review security concerns
• Evaluate test coverage implications
• Provide constructive feedback and recommendations

---

Code Review Findings

I've analyzed the tanstack-query React integration file at packages/tanstack-query/src/react.ts. While I cannot see the exact diff due to the merged state of the PR, I can provide a comprehensive review of the current code structure and potential areas for improvement.

Code Quality & Best Practices

Strengths:

• ✅ Good TypeScript type definitions with proper generic constraints
• ✅ Clean separation between type definitions and implementation
• ✅ Consistent naming conventions (camelCase for functions, PascalCase for types)
• ✅ Proper use of TypeScript utility types (SelectSubset, Omit)

Areas for Improvement:

• ⚠️ Type naming inconsistency: Line 11 has toHooks (lowercase) for the type, but line 35 has toHooks for the function. Consider renaming the type to ToHooks following TypeScript conventions
• ⚠️ Missing JSDoc comments: Public APIs should have documentation comments explaining usage

Potential Bugs & Issues

Critical Issues:

• 🚨 Stub implementation: Lines 45-78 contain placeholder implementations that return static mock data instead of actual TanStack Query hooks
• 🚨 Missing error handling: No error boundaries or error handling for failed queries/mutations

Code Issues:

• ⚠️ Uncapitalize function duplication: Line 31-33 implements a utility that could be imported from a utils package
• ⚠️ Any type usage: Line 45 uses any return type, which defeats TypeScript's type safety

Performance Considerations

• ⚡ Object.entries() usage: Line 36 uses Object.entries() which is fine for this use case
• ⚡ No memoization: The toHooks function recreates the entire hook object on every call, consider memoization for better performance

Security Concerns

• ✅ No obvious security vulnerabilities detected
• ✅ No user input handling that could lead to injection attacks
• ✅ Type-safe API design prevents most runtime errors

Test Coverage

Missing Coverage:

• ❌ No test files found for this module
• ❌ No integration tests with actual TanStack Query
• ❌ No type-level tests to ensure TypeScript inference works correctly

Recommendations:

// Consider adding tests for:
// 1. Type inference correctness
// 2. Hook generation for different schema shapes  
// 3. Error handling scenarios
// 4. Integration with actual TanStack Query

Recommended Improvements

1. Complete the implementation: Replace stub functions with actual TanStack Query hook implementations
2. Add proper TypeScript typing: Remove any types and add proper return type annotations
3. Add comprehensive tests: Unit tests, integration tests, and type tests
4. Improve documentation: Add JSDoc comments for public APIs
5. Consider error handling: Add proper error boundaries and error states

Overall Assessment

This appears to be a work-in-progress implementation of TanStack Query React hooks for ZenStack. While the type definitions are well-structured, the implementation is currently just stubs. Before this can be used in production, it needs:

• Complete implementation of actual query/mutation hooks
• Comprehensive test coverage
• Documentation and examples
• Error handling

Recommendation: Mark this as experimental/alpha until the implementation is complete.

---

[Copilot]

Pull Request Overview

This PR exports the FetchFn type from the react module of the tanstack-query client package, making it publicly available to consumers of the library.

• Adds a public export for the FetchFn type definition

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.