-
-
Notifications
You must be signed in to change notification settings - Fork 12
fix: tsjapi esm compatibility issue #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @ymc9's task —— View job PR Review: ESM Compatibility FixReviewed the ESM compatibility changes for tsjapi. Review Checklist:
Review SummaryThis PR addresses ESM compatibility issues with the Changes Made:
✅ Strengths
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ts-japi import pattern and prepares the tanstack-query package for publication. The changes address a module import compatibility issue and make the tanstack-query client publicly available.
- Changed ts-japi imports from named imports to default import with type-only named imports
- Updated all ts-japi class usages to reference the default import namespace
- Removed the "private" flag from the tanstack-query package to allow npm publication
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/server/src/api/rest/index.ts | Updated ts-japi import to use default import and prefixed all class instantiations with the namespace |
| packages/clients/tanstack-query/package.json | Removed private flag to enable package publication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WalkthroughThis PR makes the tanstack-query package publishable by removing its private flag and refactors ts-japi imports in the REST API handler from named imports to default import with type-only imports, updating all internal usages to namespace-qualified calls. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-10-21T16:09:31.218ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Chores
Refactor