merge dev to main (v3.0.0-beta.17) #364
Conversation
Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
WalkthroughThe PR updates the monorepo version from 3.0.0-beta.16 to 3.0.0-beta.17 across 19 package.json files and refactors ts-japi imports in the REST API handler to use a default namespace import with updated constructor call sites. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @ymc9's task —— View job Pull Request Review: merge dev to main (v3.0.0-beta.17)Review Tasks:
SummaryThis PR merges the dev branch to main for the v3.0.0-beta.17 release. The changes include:
Code Quality Assessment✅ Package Version Updates
✅ TypeScript Changes - ESM Compatibility Fix
What was fixed: - import { Linker, Paginator, Relator, Serializer, type SerializerOptions } from 'ts-japi';
+ import tsjapi, { type Linker, type Paginator, type Relator, type Serializer, type SerializerOptions } from 'ts-japi';
- new Linker(...)
+ new tsjapi.Linker(...)Technical Analysis:
Security & Performance Assessment🔒 Security: No Concerns
⚡ Performance: Neutral to Positive
Code Standards & Best Practices✅ Follows Repository Conventions
✅ Import Patterns
Test Coverage Considerations
|
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version from 3.0.0-beta.16 to 3.0.0-beta.17 across all packages in the monorepo. Additionally, it refactors the ts-japi imports in the REST API handler to use namespace imports instead of named imports, and removes the private flag from the @zenstackhq/tanstack-query package.
Key changes:
- Version bump from
3.0.0-beta.16to3.0.0-beta.17across all packages - Refactored
ts-japiimport to use default namespace import with type-only named imports - Changed all
new Linker,new Serializer,new Paginator, andnew Relatorconstructors to use thetsjapinamespace prefix - Removed
private: truefrom@zenstackhq/tanstack-querypackage
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated root package version to 3.0.0-beta.17 |
| packages/cli/package.json | Updated CLI package version to 3.0.0-beta.17 |
| packages/clients/tanstack-query/package.json | Updated version to 3.0.0-beta.17 and removed private flag |
| packages/common-helpers/package.json | Updated version to 3.0.0-beta.17 |
| packages/config/eslint-config/package.json | Updated version to 3.0.0-beta.17 |
| packages/config/typescript-config/package.json | Updated version to 3.0.0-beta.17 |
| packages/config/vitest-config/package.json | Updated version to 3.0.0-beta.17 |
| packages/create-zenstack/package.json | Updated version to 3.0.0-beta.17 |
| packages/dialects/sql.js/package.json | Updated version to 3.0.0-beta.17 |
| packages/language/package.json | Updated version to 3.0.0-beta.17 |
| packages/orm/package.json | Updated version to 3.0.0-beta.17 |
| packages/plugins/policy/package.json | Updated version to 3.0.0-beta.17 |
| packages/schema/package.json | Updated version to 3.0.0-beta.17 |
| packages/sdk/package.json | Updated version to 3.0.0-beta.17 |
| packages/server/package.json | Updated version to 3.0.0-beta.17 |
| packages/server/src/api/rest/index.ts | Refactored ts-japi imports to use namespace import and updated all constructor calls |
| packages/testtools/package.json | Updated version to 3.0.0-beta.17 |
| packages/zod/package.json | Updated version to 3.0.0-beta.17 |
| samples/next.js/package.json | Updated version to 3.0.0-beta.17 |
| samples/orm/package.json | Updated version to 3.0.0-beta.17 |
| tests/e2e/package.json | Updated version to 3.0.0-beta.17 |
| tests/regression/package.json | Updated version to 3.0.0-beta.17 |
Comments suppressed due to low confidence (3)
packages/server/src/api/rest/index.ts:127
- The type annotation
Serializershould be updated totsjapi.Serializerto maintain consistency with the new namespace import pattern. Since the import now usestype Serializer, this type reference should use the namespace prefix to match how the constructors are being called throughout the file.
private serializers = new Map<string, Serializer>();
packages/server/src/api/rest/index.ts:1302
- The type annotation
Linker<any>should be updated totsjapi.Linker<any>to maintain consistency with the new namespace import pattern. Since the import now usestype Linker, this type reference should use the namespace prefix to match how the constructors are being called throughout the file.
const linkers: Record<string, Linker<any>> = {};
packages/server/src/api/rest/index.ts:1351
- The type annotation
Relator<any>should be updated totsjapi.Relator<any>to maintain consistency with the new namespace import pattern. Since the import now usestype Relator, this type reference should use the namespace prefix to match how the constructors are being called throughout the file.
const relators: Record<string, Relator<any>> = {};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (22)
package.json(1 hunks)packages/cli/package.json(1 hunks)packages/clients/tanstack-query/package.json(1 hunks)packages/common-helpers/package.json(1 hunks)packages/config/eslint-config/package.json(1 hunks)packages/config/typescript-config/package.json(1 hunks)packages/config/vitest-config/package.json(1 hunks)packages/create-zenstack/package.json(1 hunks)packages/dialects/sql.js/package.json(1 hunks)packages/language/package.json(1 hunks)packages/orm/package.json(1 hunks)packages/plugins/policy/package.json(1 hunks)packages/schema/package.json(1 hunks)packages/sdk/package.json(1 hunks)packages/server/package.json(1 hunks)packages/server/src/api/rest/index.ts(8 hunks)packages/testtools/package.json(1 hunks)packages/zod/package.json(1 hunks)samples/next.js/package.json(1 hunks)samples/orm/package.json(1 hunks)tests/e2e/package.json(1 hunks)tests/regression/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-21T16:09:31.218Z
Learnt from: ymc9
Repo: zenstackhq/zenstack-v3 PR: 319
File: packages/runtime/src/client/executor/zenstack-query-executor.ts:63-72
Timestamp: 2025-10-21T16:09:31.218Z
Learning: In ZenStack, TypeDefs can be inherited by models. When a TypeDef contains fields with `map` attributes, those mapped field names need to be processed by the QueryNameMapper since they become part of the inheriting model's schema. Therefore, when checking if a schema has mapped names (e.g., in `schemaHasMappedNames`), both `schema.models` and `schema.typeDefs` must be inspected for `@map` and `map` attributes.
Applied to files:
packages/server/src/api/rest/index.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-test (20.x, sqlite)
- GitHub Check: claude-review
- GitHub Check: build-test (20.x, postgresql)
🔇 Additional comments (23)
packages/sdk/package.json (1)
3-3: Version bump looks good.Consistent with the PR objective to release v3.0.0-beta.17. No other changes to this package.
tests/regression/package.json (1)
3-3: Version bump looks good.Consistent with the PR objective to release v3.0.0-beta.17.
packages/plugins/policy/package.json (1)
3-3: Version bump looks good.Consistent with the PR objective to release v3.0.0-beta.17.
packages/language/package.json (1)
4-4: Version bump looks good.Consistent with the PR objective to release v3.0.0-beta.17.
packages/clients/tanstack-query/package.json (1)
3-3: Version bump and metadata update look good.Consistent with the PR objective to release v3.0.0-beta.17. Removal of the "private" flag (per AI summary) indicates this package is now being published publicly, which is a notable but expected change for a released version.
packages/testtools/package.json (1)
3-3: Version bump looks good.Consistent with the PR objective to release v3.0.0-beta.17.
packages/common-helpers/package.json (1)
3-3: Version bump looks good.Consistent with the PR objective to release v3.0.0-beta.17.
packages/dialects/sql.js/package.json (1)
3-3: Version bump looks good.Consistent with the PR objective to release v3.0.0-beta.17.
packages/config/typescript-config/package.json (1)
3-3: Straightforward version bump.packages/cli/package.json (1)
6-6: Straightforward version bump.packages/server/package.json (2)
3-3: Straightforward version bump.
128-128: The ts-japi import refactor is already in place and correctly implemented.The verification confirms that
packages/server/src/api/rest/index.tscontains the namespace import (import tsjapi, { type Linker, ...}) with all constructor calls properly updated to use the namespace pattern (new tsjapi.Linker(),new tsjapi.Paginator(),new tsjapi.Serializer(),new tsjapi.Relator()). The refactor has been fully applied across the file (8 locations verified). No further changes are needed.tests/e2e/package.json (1)
3-3: Straightforward version bump.packages/config/eslint-config/package.json (1)
3-3: Straightforward version bump.packages/orm/package.json (1)
3-3: Straightforward version bump.package.json (1)
3-3: Straightforward version bump.packages/config/vitest-config/package.json (1)
4-4: Straightforward version bump.samples/next.js/package.json (1)
3-3: LGTM! Version bump looks correct.The version increment from 3.0.0-beta.16 to 3.0.0-beta.17 aligns with the PR objective for the beta release.
samples/orm/package.json (1)
3-3: LGTM! Version bump is consistent with the release.The version update matches the expected 3.0.0-beta.17 release across the monorepo.
packages/schema/package.json (1)
3-3: LGTM! Version update is correct.Consistent version increment as part of the 3.0.0-beta.17 release.
packages/zod/package.json (1)
3-3: LGTM! Version bump applied correctly.The version increment aligns with the monorepo-wide release to 3.0.0-beta.17.
packages/create-zenstack/package.json (1)
3-3: LGTM! Version update is consistent.The version change matches the release objective for 3.0.0-beta.17.
packages/server/src/api/rest/index.ts (1)
613-616: Constructor usage updates are consistent and correct.All constructor calls for
Linker,Paginator,Serializer, andRelatorhave been updated to use thetsjapinamespace consistently throughout the file. The refactoring appears complete with no mixed usage patterns.Also applies to: 675-677, 832-851, 1115-1117, 1313-1317, 1331-1339, 1365-1383
Summary by CodeRabbit