Skip to content

fix(#300): handle invalid json in openapi query params gracefully #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix(#300): handle invalid json in openapi query params gracefully #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/server/src/openapi/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,11 @@ export async function handleRequest({
if (method !== 'GET') {
return { status: 400, body: { message: 'invalid request method, only GET is supported' } };
}
args = query?.q ? unmarshal(query.q as string) : {};
try {
args = query?.q ? unmarshal(query.q as string) : {};
} catch {
return { status: 400, body: { message: 'query param must contain valid JSON' } };
}
break;

case 'update':
Expand All @@ -158,7 +162,11 @@ export async function handleRequest({
if (method !== 'DELETE') {
return { status: 400, body: { message: 'invalid request method, only DELETE is supported' } };
}
args = query?.q ? unmarshal(query.q as string) : {};
try {
args = query?.q ? unmarshal(query.q as string) : {};
} catch {
return { status: 400, body: { message: 'query param must contain valid JSON' } };
}
break;

default:
Expand Down